Skip to content

Commit a306b97

Browse files
ssuthiku-amdjfvogel
authored andcommitted
KVM: x86: lapic: Rename [GET/SET]_APIC_DEST_FIELD to [GET/SET]_XAPIC_DEST_FIELD
To signify that the macros only support 8-bit xAPIC destination ID. Suggested-by: Maxim Levitsky <[email protected]> Reviewed-by: Maxim Levitsky <[email protected]> Reviewed-by: Pankaj Gupta <[email protected]> Signed-off-by: Suravee Suthikulpanit <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> (cherry picked from commit bf348f6) Orabug: 34817119 Signed-off-by: Alejandro Jimenez <[email protected]> Reviewed-by: Boris Ostrovsky <[email protected]> (cherry picked from commit 65134ecc1302bcee6a5ee9171b926826eb683e3a) Signed-off-by: Jack Vogel <[email protected]>
1 parent 5b47cc9 commit a306b97

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

arch/x86/hyperv/hv_apic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ static void hv_apic_icr_write(u32 low, u32 id)
4646
{
4747
u64 reg_val;
4848

49-
reg_val = SET_APIC_DEST_FIELD(id);
49+
reg_val = SET_XAPIC_DEST_FIELD(id);
5050
reg_val = reg_val << 32;
5151
reg_val |= low;
5252

arch/x86/include/asm/apicdef.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@
8989
#define APIC_DM_EXTINT 0x00700
9090
#define APIC_VECTOR_MASK 0x000FF
9191
#define APIC_ICR2 0x310
92-
#define GET_APIC_DEST_FIELD(x) (((x) >> 24) & 0xFF)
93-
#define SET_APIC_DEST_FIELD(x) ((x) << 24)
92+
#define GET_XAPIC_DEST_FIELD(x) (((x) >> 24) & 0xFF)
93+
#define SET_XAPIC_DEST_FIELD(x) ((x) << 24)
9494
#define APIC_LVTT 0x320
9595
#define APIC_LVTTHMR 0x330
9696
#define APIC_LVTPC 0x340

arch/x86/kernel/apic/apic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ void native_apic_icr_write(u32 low, u32 id)
275275
unsigned long flags;
276276

277277
local_irq_save(flags);
278-
apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(id));
278+
apic_write(APIC_ICR2, SET_XAPIC_DEST_FIELD(id));
279279
apic_write(APIC_ICR, low);
280280
local_irq_restore(flags);
281281
}

arch/x86/kernel/apic/ipi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ void native_send_call_func_ipi(const struct cpumask *mask)
9999

100100
static inline int __prepare_ICR2(unsigned int mask)
101101
{
102-
return SET_APIC_DEST_FIELD(mask);
102+
return SET_XAPIC_DEST_FIELD(mask);
103103
}
104104

105105
static inline void __xapic_wait_icr_idle(void)

arch/x86/kvm/lapic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1329,7 +1329,7 @@ void kvm_apic_send_ipi(struct kvm_lapic *apic, u32 icr_low, u32 icr_high)
13291329
if (apic_x2apic_mode(apic))
13301330
irq.dest_id = icr_high;
13311331
else
1332-
irq.dest_id = GET_APIC_DEST_FIELD(icr_high);
1332+
irq.dest_id = GET_XAPIC_DEST_FIELD(icr_high);
13331333

13341334
trace_kvm_apic_ipi(icr_low, irq.dest_id);
13351335

arch/x86/kvm/svm/avic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm, struct kvm_lapic *source
304304
if (apic_x2apic_mode(source))
305305
dest = icrh;
306306
else
307-
dest = GET_APIC_DEST_FIELD(icrh);
307+
dest = GET_XAPIC_DEST_FIELD(icrh);
308308

309309
if (dest_mode == APIC_DEST_PHYSICAL) {
310310
/* broadcast destination, use slow path */
@@ -406,7 +406,7 @@ static void avic_kick_target_vcpus(struct kvm *kvm, struct kvm_lapic *source,
406406
*/
407407
kvm_for_each_vcpu(i, vcpu, kvm) {
408408
if (kvm_apic_match_dest(vcpu, source, icrl & APIC_SHORT_MASK,
409-
GET_APIC_DEST_FIELD(icrh),
409+
GET_XAPIC_DEST_FIELD(icrh),
410410
icrl & APIC_DEST_MASK)) {
411411
vcpu->arch.apic->irr_pending = true;
412412
svm_complete_interrupt_delivery(vcpu,

0 commit comments

Comments
 (0)