Skip to content

Commit a315da5

Browse files
rddunlapPeter Zijlstra
authored andcommitted
sched/fair: Fix all kernel-doc warnings
Quieten all kernel-doc warnings in kernel/sched/fair.c: kernel/sched/fair.c:3663: warning: No description found for return value of 'update_cfs_rq_load_avg' kernel/sched/fair.c:8601: warning: No description found for return value of 'asym_smt_can_pull_tasks' kernel/sched/fair.c:8673: warning: Function parameter or member 'sds' not described in 'update_sg_lb_stats' kernel/sched/fair.c:9483: warning: contents before sections Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Ricardo Neri <[email protected]> Acked-by: Vincent Guittot <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent b171501 commit a315da5

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

kernel/sched/fair.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3668,7 +3668,7 @@ static inline void add_tg_cfs_propagate(struct cfs_rq *cfs_rq, long runnable_sum
36683668
*
36693669
* cfs_rq->avg is used for task_h_load() and update_cfs_share() for example.
36703670
*
3671-
* Returns true if the load decayed or we removed load.
3671+
* Return: true if the load decayed or we removed load.
36723672
*
36733673
* Since both these conditions indicate a changed cfs_rq->avg.load we should
36743674
* call update_tg_load_avg() when this function returns true.
@@ -8573,6 +8573,8 @@ group_type group_classify(unsigned int imbalance_pct,
85738573
*
85748574
* If @sg does not have SMT siblings, only pull tasks if all of the SMT siblings
85758575
* of @dst_cpu are idle and @sg has lower priority.
8576+
*
8577+
* Return: true if @dst_cpu can pull tasks, false otherwise.
85768578
*/
85778579
static bool asym_smt_can_pull_tasks(int dst_cpu, struct sd_lb_stats *sds,
85788580
struct sg_lb_stats *sgs,
@@ -8648,6 +8650,7 @@ sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs
86488650
/**
86498651
* update_sg_lb_stats - Update sched_group's statistics for load balancing.
86508652
* @env: The load balancing environment.
8653+
* @sds: Load-balancing data with statistics of the local group.
86518654
* @group: sched_group whose statistics are to be updated.
86528655
* @sgs: variable to hold the statistics for this group.
86538656
* @sg_status: Holds flag indicating the status of the sched_group
@@ -9455,12 +9458,11 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
94559458
/**
94569459
* find_busiest_group - Returns the busiest group within the sched_domain
94579460
* if there is an imbalance.
9461+
* @env: The load balancing environment.
94589462
*
94599463
* Also calculates the amount of runnable load which should be moved
94609464
* to restore balance.
94619465
*
9462-
* @env: The load balancing environment.
9463-
*
94649466
* Return: - The busiest group if imbalance exists.
94659467
*/
94669468
static struct sched_group *find_busiest_group(struct lb_env *env)

0 commit comments

Comments
 (0)