net: dsa: lan9303: Fix error return code in lan9303_check_device()

Wei Yongjun · davem330 · commit a31e795a3b4d · 2018-01-05T11:24:54.000-05:00
Fix to return error code -ENODEV from the chip not found error handling
case instead of 0(ret have been overwritten to 0 by lan9303_read()), as
done elsewhere in this function.

Signed-off-by: Wei Yongjun &lt;weiyongjun1@huawei.com&gt;
Reviewed-by: Egil Hjelmeland &lt;privat@egil-hjelmeland.no&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
@@ -865,7 +865,7 @@ static int lan9303_check_device(struct lan9303 *chip)
 	if ((reg >> 16) != LAN9303_CHIP_ID) {
 		dev_err(chip->dev, "expecting LAN9303 chip, but found: %X\n",
 			reg >> 16);
-		return ret;
+		return -ENODEV;
 	}
 
 	/* The default state of the LAN9303 device is to forward packets between

Original file line number	Diff line number	Diff line change
`@@ -865,7 +865,7 @@ static int lan9303_check_device(struct lan9303 *chip)`
`865`	`865`	`if ((reg >> 16) != LAN9303_CHIP_ID) {`
`866`	`866`	`dev_err(chip->dev, "expecting LAN9303 chip, but found: %X\n",`
`867`	`867`	`reg >> 16);`
`868`		`- return ret;`
	`868`	`+ return -ENODEV;`
`869`	`869`	`}`
`870`	`870`
`871`	`871`	`/* The default state of the LAN9303 device is to forward packets between`