net: amd-xgbe: fix comparison to bitshift when dealing with a mask

Wolfram Sang · davem330 · commit a3276892db7a · 2018-02-06T11:24:51.000-05:00
Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.

Signed-off-by: Wolfram Sang &lt;wsa+renesas@sang-engineering.com&gt;
Acked-by: Tom Lendacky &lt;thomas.lendacky@amd.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data)
 
 		reissue_mask = 1 << 0;
 		if (!pdata->per_channel_irq)
-			reissue_mask |= 0xffff < 4;
+			reissue_mask |= 0xffff << 4;
 
 		XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask);
 	}

Original file line number	Diff line number	Diff line change
`@@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data)`
`595`	`595`
`596`	`596`	`reissue_mask = 1 << 0;`
`597`	`597`	`if (!pdata->per_channel_irq)`
`598`		`- reissue_mask \|= 0xffff < 4;`
	`598`	`+ reissue_mask \|= 0xffff << 4;`
`599`	`599`
`600`	`600`	`XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask);`
`601`	`601`	`}`