Skip to content

Commit a34dc4a

Browse files
namjaejeonSteve French
authored andcommitted
ksmbd: downgrade ndr version error message to debug
When user switch samba to ksmbd, The following message flood is coming when accessing files. Samba seems to changs dos attribute version to v5. This patch downgrade ndr version error message to debug. $ dmesg ... [68971.766914] ksmbd: v5 version is not supported [68971.779808] ksmbd: v5 version is not supported [68971.871544] ksmbd: v5 version is not supported [68971.910135] ksmbd: v5 version is not supported ... Cc: [email protected] Fixes: e2f3448 ("cifsd: add server-side procedures for SMB3") Signed-off-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 62c487b commit a34dc4a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

fs/ksmbd/ndr.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da)
242242
return ret;
243243

244244
if (da->version != 3 && da->version != 4) {
245-
pr_err("v%d version is not supported\n", da->version);
245+
ksmbd_debug(VFS, "v%d version is not supported\n", da->version);
246246
return -EINVAL;
247247
}
248248

@@ -251,7 +251,7 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da)
251251
return ret;
252252

253253
if (da->version != version2) {
254-
pr_err("ndr version mismatched(version: %d, version2: %d)\n",
254+
ksmbd_debug(VFS, "ndr version mismatched(version: %d, version2: %d)\n",
255255
da->version, version2);
256256
return -EINVAL;
257257
}
@@ -457,15 +457,15 @@ int ndr_decode_v4_ntacl(struct ndr *n, struct xattr_ntacl *acl)
457457
if (ret)
458458
return ret;
459459
if (acl->version != 4) {
460-
pr_err("v%d version is not supported\n", acl->version);
460+
ksmbd_debug(VFS, "v%d version is not supported\n", acl->version);
461461
return -EINVAL;
462462
}
463463

464464
ret = ndr_read_int32(n, &version2);
465465
if (ret)
466466
return ret;
467467
if (acl->version != version2) {
468-
pr_err("ndr version mismatched(version: %d, version2: %d)\n",
468+
ksmbd_debug(VFS, "ndr version mismatched(version: %d, version2: %d)\n",
469469
acl->version, version2);
470470
return -EINVAL;
471471
}

0 commit comments

Comments
 (0)