Skip to content

Commit a446f4b

Browse files
harshimogalapallijfvogel
authored andcommitted
uek-rpm: Add --no-run-if-empty option to xargs for a remove command
This change is already present in LUCI, make this change to UEK8 as well. This is useful when you really don't have any of the modules.list, let us say in future we are adding some new flavour like embedded for UEK8 and it doesn't have modules-extra package which is when we don't have modules-extra.list file to remove, in those cases it is useful to use --no-run-if-empty option to avoid running into a failure. Orabug: 37453041 Signed-off-by: Harshit Mogalapalli <[email protected]> Reviewed-by: Jack Vogel <[email protected]>
1 parent 972a308 commit a446f4b

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

uek-rpm/ol10/kernel-uek.spec

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,8 +1346,8 @@ BuildKernel() {
13461346
cp -r lib/modules/$KernelVer/* restore/.
13471347

13481348
# don't include anything going into kernel%{?variant}-modules-(extra|deprecated) in the file lists
1349-
grep '^/lib/modules' ${modlistVariant}-modules-extra.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1350-
grep '^/lib/modules' ${modlistVariant}-modules-deprecated.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1349+
grep '^/lib/modules' ${modlistVariant}-modules-extra.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1350+
grep '^/lib/modules' ${modlistVariant}-modules-deprecated.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13511351

13521352
# Run depmod on the resulting module tree and make sure it isn't broken
13531353
depmod -b . -aeF ./System.map $KernelVer &> depmod.out
@@ -1362,10 +1362,10 @@ BuildKernel() {
13621362
remove_depmod_files
13631363

13641364
# don't include anything going into kernel%{?variant}-modules-(desktop|usb|wireless|netfilter) in the file lists
1365-
grep '^/lib/modules' ${modlistVariant}-modules-desktop.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1366-
grep '^/lib/modules' ${modlistVariant}-modules-extra-netfilter.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1367-
grep '^/lib/modules' ${modlistVariant}-modules-usb.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1368-
grep '^/lib/modules' ${modlistVariant}-modules-wireless.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1365+
grep '^/lib/modules' ${modlistVariant}-modules-desktop.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1366+
grep '^/lib/modules' ${modlistVariant}-modules-extra-netfilter.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1367+
grep '^/lib/modules' ${modlistVariant}-modules-usb.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1368+
grep '^/lib/modules' ${modlistVariant}-modules-wireless.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13691369
depmod -b . -aeF ./System.map $KernelVer &> depmod.out
13701370
# Run depmod on the resulting module tree and make sure it isn't broken
13711371
if [ -s depmod.out ]; then
@@ -1378,7 +1378,7 @@ BuildKernel() {
13781378

13791379
remove_depmod_files
13801380

1381-
grep '^/lib/modules' ${modlistVariant}-modules.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1381+
grep '^/lib/modules' ${modlistVariant}-modules.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13821382

13831383
# Run depmod on the resulting module tree and make sure it isn't broken
13841384
depmod -b . -aeF ./System.map $KernelVer &> depmod.out

uek-rpm/ol9/kernel-uek.spec

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,8 +1356,8 @@ BuildKernel() {
13561356
cp -r lib/modules/$KernelVer/* restore/.
13571357

13581358
# don't include anything going into kernel%{?variant}-modules-(extra|deprecated) in the file lists
1359-
grep '^/lib/modules' ${modlistVariant}-modules-extra.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1360-
grep '^/lib/modules' ${modlistVariant}-modules-deprecated.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1359+
grep '^/lib/modules' ${modlistVariant}-modules-extra.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1360+
grep '^/lib/modules' ${modlistVariant}-modules-deprecated.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13611361

13621362
# Run depmod on the resulting module tree and make sure it isn't broken
13631363
depmod -b . -aeF ./System.map $KernelVer &> depmod.out
@@ -1372,10 +1372,10 @@ BuildKernel() {
13721372
remove_depmod_files
13731373

13741374
# don't include anything going into kernel%{?variant}-modules-(desktop|usb|wireless|netfilter) in the file lists
1375-
grep '^/lib/modules' ${modlistVariant}-modules-desktop.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1376-
grep '^/lib/modules' ${modlistVariant}-modules-extra-netfilter.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1377-
grep '^/lib/modules' ${modlistVariant}-modules-usb.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1378-
grep '^/lib/modules' ${modlistVariant}-modules-wireless.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1375+
grep '^/lib/modules' ${modlistVariant}-modules-desktop.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1376+
grep '^/lib/modules' ${modlistVariant}-modules-extra-netfilter.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1377+
grep '^/lib/modules' ${modlistVariant}-modules-usb.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
1378+
grep '^/lib/modules' ${modlistVariant}-modules-wireless.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13791379
depmod -b . -aeF ./System.map $KernelVer &> depmod.out
13801380
# Run depmod on the resulting module tree and make sure it isn't broken
13811381
if [ -s depmod.out ]; then
@@ -1388,7 +1388,7 @@ BuildKernel() {
13881388

13891389
remove_depmod_files
13901390

1391-
grep '^/lib/modules' ${modlistVariant}-modules.list | sed -e 's/^\///' %{?unzipsed} | xargs rm
1391+
grep '^/lib/modules' ${modlistVariant}-modules.list | sed -e 's/^\///' %{?unzipsed} | xargs --no-run-if-empty rm
13921392

13931393
# Run depmod on the resulting module tree and make sure it isn't broken
13941394
depmod -b . -aeF ./System.map $KernelVer &> depmod.out

0 commit comments

Comments
 (0)