Skip to content

Commit a48350c

Browse files
atbrady-intelJeff Kirsher
authored andcommitted
i40e: broadcast filters can trigger overflow promiscuous
When adding a bunch of VLANs to all the ports on a device, it's possible to run out of space for broadcast filters. The driver should trigger overflow promiscuous in this circumstance to prevent traffic from being unexpectedly dropped. Signed-off-by: Alan Brady <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 7be78aa commit a48350c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/net/ethernet/intel/i40e/i40e_main.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2177,11 +2177,13 @@ i40e_aqc_broadcast_filter(struct i40e_vsi *vsi, const char *vsi_name,
21772177
NULL);
21782178
}
21792179

2180-
if (aq_ret)
2180+
if (aq_ret) {
2181+
set_bit(__I40E_VSI_OVERFLOW_PROMISC, vsi->state);
21812182
dev_warn(&vsi->back->pdev->dev,
2182-
"Error %s setting broadcast promiscuous mode on %s\n",
2183+
"Error %s, forcing overflow promiscuous on %s\n",
21832184
i40e_aq_str(hw, hw->aq.asq_last_status),
21842185
vsi_name);
2186+
}
21852187

21862188
return aq_ret;
21872189
}

0 commit comments

Comments
 (0)