Skip to content

Commit a50924e

Browse files
committed
btrfs: drop constant param from btrfs_release_extent_buffer_page
All callers use the same value, simplify the function. Signed-off-by: David Sterba <[email protected]>
1 parent 2755a0d commit a50924e

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

fs/btrfs/extent_io.c

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4450,19 +4450,16 @@ int extent_buffer_under_io(struct extent_buffer *eb)
44504450
/*
44514451
* Helper for releasing extent buffer page.
44524452
*/
4453-
static void btrfs_release_extent_buffer_page(struct extent_buffer *eb,
4454-
unsigned long start_idx)
4453+
static void btrfs_release_extent_buffer_page(struct extent_buffer *eb)
44554454
{
44564455
unsigned long index;
4457-
unsigned long num_pages;
44584456
struct page *page;
44594457
int mapped = !test_bit(EXTENT_BUFFER_DUMMY, &eb->bflags);
44604458

44614459
BUG_ON(extent_buffer_under_io(eb));
44624460

4463-
num_pages = num_extent_pages(eb->start, eb->len);
4464-
index = start_idx + num_pages;
4465-
if (start_idx >= index)
4461+
index = num_extent_pages(eb->start, eb->len);
4462+
if (index == 0)
44664463
return;
44674464

44684465
do {
@@ -4498,15 +4495,15 @@ static void btrfs_release_extent_buffer_page(struct extent_buffer *eb,
44984495
/* One for when we alloced the page */
44994496
page_cache_release(page);
45004497
}
4501-
} while (index != start_idx);
4498+
} while (index != 0);
45024499
}
45034500

45044501
/*
45054502
* Helper for releasing the extent buffer.
45064503
*/
45074504
static inline void btrfs_release_extent_buffer(struct extent_buffer *eb)
45084505
{
4509-
btrfs_release_extent_buffer_page(eb, 0);
4506+
btrfs_release_extent_buffer_page(eb);
45104507
__free_extent_buffer(eb);
45114508
}
45124509

@@ -4863,7 +4860,7 @@ static int release_extent_buffer(struct extent_buffer *eb)
48634860
}
48644861

48654862
/* Should be safe to release our pages at this point */
4866-
btrfs_release_extent_buffer_page(eb, 0);
4863+
btrfs_release_extent_buffer_page(eb);
48674864
call_rcu(&eb->rcu_head, btrfs_release_extent_buffer_rcu);
48684865
return 1;
48694866
}

0 commit comments

Comments
 (0)