gve: fix -ENOMEM null check on a page allocation

Colin Ian King · davem330 · commit a51df9f8da43 · 2019-07-03T13:53:07.000-07:00
Currently the check to see if a page is allocated is incorrect and is checking if the pointer page is null, not *page as intended. Fix this. Addresses-Coverity: ("Dereference before null check") Fixes: f5cedc8 ("gve: Add transmit and receive support") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
@@ -518,7 +518,7 @@ int gve_alloc_page(struct device *dev, struct page **page, dma_addr_t *dma,
 		   enum dma_data_direction dir)
 {
 	*page = alloc_page(GFP_KERNEL);
-	if (!page)
+	if (!*page)
 		return -ENOMEM;
 	*dma = dma_map_page(dev, *page, 0, PAGE_SIZE, dir);
 	if (dma_mapping_error(dev, *dma)) {

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ int gve_alloc_page(struct device dev, struct page page, dma_addr_t dma,`
`518`	`518`	`enum dma_data_direction dir)`
`519`	`519`	`{`
`520`	`520`	`*page = alloc_page(GFP_KERNEL);`
`521`		`- if (!page)`
	`521`	`+ if (!*page)`
`522`	`522`	`return -ENOMEM;`
`523`	`523`	`dma = dma_map_page(dev, page, 0, PAGE_SIZE, dir);`
`524`	`524`	`if (dma_mapping_error(dev, *dma)) {`