Skip to content

Commit a52be1c

Browse files
kevloJeff Garzik
authored andcommitted
8139cp: use netdev_alloc_skb
This patch uses netdev_alloc_skb. This sets skb->dev and allows arch specific allocation. Also cleanup the alignment code. Signed-off-by: Kevin Lo <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
1 parent b26b555 commit a52be1c

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/net/8139cp.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ MODULE_PARM_DESC (multicast_filter_limit, "8139cp: maximum number of filtered mu
127127
(CP)->tx_tail - (CP)->tx_head - 1)
128128

129129
#define PKT_BUF_SZ 1536 /* Size of each temporary Rx buffer.*/
130-
#define RX_OFFSET 2
131130
#define CP_INTERNAL_PHY 32
132131

133132
/* The following settings are log_2(bytes)-4: 0 == 16 bytes .. 6==1024, 7==end of packet. */
@@ -552,14 +551,14 @@ static int cp_rx_poll(struct napi_struct *napi, int budget)
552551
printk(KERN_DEBUG "%s: rx slot %d status 0x%x len %d\n",
553552
dev->name, rx_tail, status, len);
554553

555-
buflen = cp->rx_buf_sz + RX_OFFSET;
556-
new_skb = dev_alloc_skb (buflen);
554+
buflen = cp->rx_buf_sz + NET_IP_ALIGN;
555+
new_skb = netdev_alloc_skb(dev, buflen);
557556
if (!new_skb) {
558557
dev->stats.rx_dropped++;
559558
goto rx_next;
560559
}
561560

562-
skb_reserve(new_skb, RX_OFFSET);
561+
skb_reserve(new_skb, NET_IP_ALIGN);
563562

564563
dma_unmap_single(&cp->pdev->dev, mapping,
565564
buflen, PCI_DMA_FROMDEVICE);
@@ -1051,19 +1050,20 @@ static void cp_init_hw (struct cp_private *cp)
10511050
cpw8_f(Cfg9346, Cfg9346_Lock);
10521051
}
10531052

1054-
static int cp_refill_rx (struct cp_private *cp)
1053+
static int cp_refill_rx(struct cp_private *cp)
10551054
{
1055+
struct net_device *dev = cp->dev;
10561056
unsigned i;
10571057

10581058
for (i = 0; i < CP_RX_RING_SIZE; i++) {
10591059
struct sk_buff *skb;
10601060
dma_addr_t mapping;
10611061

1062-
skb = dev_alloc_skb(cp->rx_buf_sz + RX_OFFSET);
1062+
skb = netdev_alloc_skb(dev, cp->rx_buf_sz + NET_IP_ALIGN);
10631063
if (!skb)
10641064
goto err_out;
10651065

1066-
skb_reserve(skb, RX_OFFSET);
1066+
skb_reserve(skb, NET_IP_ALIGN);
10671067

10681068
mapping = dma_map_single(&cp->pdev->dev, skb->data,
10691069
cp->rx_buf_sz, PCI_DMA_FROMDEVICE);

0 commit comments

Comments
 (0)