Skip to content

Commit a63abe3

Browse files
arndbmchehab
authored andcommitted
[media] exynos4-is: make VIDEO_SAMSUNG_EXYNOS4_IS tristate
With CONFIG_V4L2=m and VIDEO_SAMSUNG_EXYNOS4_IS=y, we can select the individual drivers as built-in code when that should not be possible: drivers/built-in.o: In function `s5pcsis_set_fmt': policy.c:(.text+0x13afdc): undefined reference to `v4l_bound_align_image' drivers/built-in.o: In function `s5pcsis_probe': policy.c:(.text+0x13b440): undefined reference to `v4l2_of_parse_endpoint' policy.c:(.text+0x13b72c): undefined reference to `v4l2_subdev_init' Changing VIDEO_SAMSUNG_EXYNOS4_IS to tristate means that the dependency from CONFIG_V4L2 propates to the individual Kconfig symbols and they can only be built as loadable modules if V4L2 or any other of the dependencies itself is a module. Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 4205207 commit a63abe3

File tree

1 file changed

+1
-1
lines changed
  • drivers/media/platform/exynos4-is

1 file changed

+1
-1
lines changed

drivers/media/platform/exynos4-is/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
config VIDEO_SAMSUNG_EXYNOS4_IS
3-
bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver"
3+
tristate "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver"
44
depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
55
depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
66
depends on OF && COMMON_CLK

0 commit comments

Comments
 (0)