Skip to content

Commit a66b588

Browse files
joabreudavem330
authored andcommitted
net: stmmac: Do not disable interrupts when cleaning TX
This is a performance killer and anyways the interrupts are being disabled by RX NAPI so no need to disable them again. Signed-off-by: Jose Abreu <[email protected]> Cc: Joao Pinto <[email protected]> Cc: David S. Miller <[email protected]> Cc: Giuseppe Cavallaro <[email protected]> Cc: Alexandre Torgue <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5b0d7d7 commit a66b588

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2061,10 +2061,8 @@ static int stmmac_napi_check(struct stmmac_priv *priv, u32 chan)
20612061
napi_schedule_irqoff(&ch->rx_napi);
20622062
}
20632063

2064-
if ((status & handle_tx) && (chan < priv->plat->tx_queues_to_use)) {
2065-
stmmac_disable_dma_irq(priv, priv->ioaddr, chan);
2064+
if ((status & handle_tx) && (chan < priv->plat->tx_queues_to_use))
20662065
napi_schedule_irqoff(&ch->tx_napi);
2067-
}
20682066

20692067
return status;
20702068
}
@@ -3570,8 +3568,8 @@ static int stmmac_napi_poll_tx(struct napi_struct *napi, int budget)
35703568
work_done = stmmac_tx_clean(priv, DMA_TX_SIZE, chan);
35713569
work_done = min(work_done, budget);
35723570

3573-
if (work_done < budget && napi_complete_done(napi, work_done))
3574-
stmmac_enable_dma_irq(priv, priv->ioaddr, chan);
3571+
if (work_done < budget)
3572+
napi_complete_done(napi, work_done);
35753573

35763574
/* Force transmission restart */
35773575
tx_q = &priv->tx_queue[chan];

0 commit comments

Comments
 (0)