Skip to content

Commit a670499

Browse files
sowminivLinuxMinion
authored andcommitted
rds: tcp: use sock_create_lite() to create the accept socket
There are two problems with calling sock_create_kern() from rds_tcp_accept_one() 1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept() 2. The new_sock->sk is a leaked reference in sock_graft() which expects to find a null parent->sk Avoid these problems by calling sock_create_lite(). Orabug: 26477756 Signed-off-by: Sowmini Varadhan <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Reviewed-by: Yuval Shaia <[email protected]>
1 parent 0d47de1 commit a670499

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/rds/tcp_listen.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ int rds_tcp_accept_one(struct socket *sock)
127127
if (!sock) /* module unload or netns delete in progress */
128128
return -ENETUNREACH;
129129

130-
ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family,
130+
ret = sock_create_lite(sock->sk->sk_family,
131131
sock->sk->sk_type, sock->sk->sk_protocol,
132132
&new_sock);
133133
if (ret)

0 commit comments

Comments
 (0)