Skip to content

Commit a6a188e

Browse files
YueHaibingdavem330
authored andcommitted
libcxgb,cxgb4: use __skb_put_zero to simplfy code
use helper __skb_put_zero to replace the pattern of __skb_put() && memset() Signed-off-by: YueHaibing <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1baf5eb commit a6a188e

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ static int set_tcb_field(struct adapter *adap, struct filter_entry *f,
6464
if (!skb)
6565
return -ENOMEM;
6666

67-
req = (struct cpl_set_tcb_field *)__skb_put(skb, sizeof(*req));
68-
memset(req, 0, sizeof(*req));
67+
req = (struct cpl_set_tcb_field *)__skb_put_zero(skb, sizeof(*req));
6968
INIT_TP_WR_CPL(req, CPL_SET_TCB_FIELD, ftid);
7069
req->reply_ctrl = htons(REPLY_CHAN_V(0) |
7170
QUEUENO_V(adap->sge.fw_evtq.abs_id) |

drivers/net/ethernet/chelsio/cxgb4/srq.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ int cxgb4_get_srq_entry(struct net_device *dev,
8484
if (!skb)
8585
return -ENOMEM;
8686
req = (struct cpl_srq_table_req *)
87-
__skb_put(skb, sizeof(*req));
88-
memset(req, 0, sizeof(*req));
87+
__skb_put_zero(skb, sizeof(*req));
8988
INIT_TP_WR(req, 0);
9089
OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_SRQ_TABLE_REQ,
9190
TID_TID_V(srq_idx) |

drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ cxgb_mk_tid_release(struct sk_buff *skb, u32 len, u32 tid, u16 chan)
9090
{
9191
struct cpl_tid_release *req;
9292

93-
req = __skb_put(skb, len);
94-
memset(req, 0, len);
93+
req = __skb_put_zero(skb, len);
9594

9695
INIT_TP_WR(req, tid);
9796
OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_TID_RELEASE, tid));
@@ -104,8 +103,7 @@ cxgb_mk_close_con_req(struct sk_buff *skb, u32 len, u32 tid, u16 chan,
104103
{
105104
struct cpl_close_con_req *req;
106105

107-
req = __skb_put(skb, len);
108-
memset(req, 0, len);
106+
req = __skb_put_zero(skb, len);
109107

110108
INIT_TP_WR(req, tid);
111109
OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_CLOSE_CON_REQ, tid));
@@ -119,8 +117,7 @@ cxgb_mk_abort_req(struct sk_buff *skb, u32 len, u32 tid, u16 chan,
119117
{
120118
struct cpl_abort_req *req;
121119

122-
req = __skb_put(skb, len);
123-
memset(req, 0, len);
120+
req = __skb_put_zero(skb, len);
124121

125122
INIT_TP_WR(req, tid);
126123
OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_ABORT_REQ, tid));
@@ -134,8 +131,7 @@ cxgb_mk_abort_rpl(struct sk_buff *skb, u32 len, u32 tid, u16 chan)
134131
{
135132
struct cpl_abort_rpl *rpl;
136133

137-
rpl = __skb_put(skb, len);
138-
memset(rpl, 0, len);
134+
rpl = __skb_put_zero(skb, len);
139135

140136
INIT_TP_WR(rpl, tid);
141137
OPCODE_TID(rpl) = cpu_to_be32(MK_OPCODE_TID(CPL_ABORT_RPL, tid));
@@ -149,8 +145,7 @@ cxgb_mk_rx_data_ack(struct sk_buff *skb, u32 len, u32 tid, u16 chan,
149145
{
150146
struct cpl_rx_data_ack *req;
151147

152-
req = __skb_put(skb, len);
153-
memset(req, 0, len);
148+
req = __skb_put_zero(skb, len);
154149

155150
INIT_TP_WR(req, tid);
156151
OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_RX_DATA_ACK, tid));

0 commit comments

Comments
 (0)