Skip to content

Commit a750276

Browse files
ogerlitzSaeed Mahameed
authored andcommitted
net/mlx5: Reorder few command cases to reflect their natural order
Move the commands related to scheduling elements and vport qos to a suitable location (according to the MLX5_CMD_OP enum values) in the command string and internal error helpers. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz <[email protected]> Reviewed-by: Hadar Hen Zion <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent e753b2b commit a750276

File tree

1 file changed

+12
-12
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+12
-12
lines changed

drivers/net/ethernet/mellanox/mlx5/core/cmd.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,8 @@ static int mlx5_internal_err_ret_value(struct mlx5_core_dev *dev, u16 op,
279279
case MLX5_CMD_OP_DESTROY_XRC_SRQ:
280280
case MLX5_CMD_OP_DESTROY_DCT:
281281
case MLX5_CMD_OP_DEALLOC_Q_COUNTER:
282+
case MLX5_CMD_OP_DESTROY_SCHEDULING_ELEMENT:
283+
case MLX5_CMD_OP_DESTROY_QOS_PARA_VPORT:
282284
case MLX5_CMD_OP_DEALLOC_PD:
283285
case MLX5_CMD_OP_DEALLOC_UAR:
284286
case MLX5_CMD_OP_DETACH_FROM_MCG:
@@ -305,8 +307,6 @@ static int mlx5_internal_err_ret_value(struct mlx5_core_dev *dev, u16 op,
305307
case MLX5_CMD_OP_SET_FLOW_TABLE_ENTRY:
306308
case MLX5_CMD_OP_SET_FLOW_TABLE_ROOT:
307309
case MLX5_CMD_OP_DEALLOC_ENCAP_HEADER:
308-
case MLX5_CMD_OP_DESTROY_SCHEDULING_ELEMENT:
309-
case MLX5_CMD_OP_DESTROY_QOS_PARA_VPORT:
310310
return MLX5_CMD_STAT_OK;
311311

312312
case MLX5_CMD_OP_QUERY_HCA_CAP:
@@ -363,6 +363,10 @@ static int mlx5_internal_err_ret_value(struct mlx5_core_dev *dev, u16 op,
363363
case MLX5_CMD_OP_QUERY_Q_COUNTER:
364364
case MLX5_CMD_OP_SET_RATE_LIMIT:
365365
case MLX5_CMD_OP_QUERY_RATE_LIMIT:
366+
case MLX5_CMD_OP_CREATE_SCHEDULING_ELEMENT:
367+
case MLX5_CMD_OP_QUERY_SCHEDULING_ELEMENT:
368+
case MLX5_CMD_OP_MODIFY_SCHEDULING_ELEMENT:
369+
case MLX5_CMD_OP_CREATE_QOS_PARA_VPORT:
366370
case MLX5_CMD_OP_ALLOC_PD:
367371
case MLX5_CMD_OP_ALLOC_UAR:
368372
case MLX5_CMD_OP_CONFIG_INT_MODERATION:
@@ -414,10 +418,6 @@ static int mlx5_internal_err_ret_value(struct mlx5_core_dev *dev, u16 op,
414418
case MLX5_CMD_OP_ALLOC_FLOW_COUNTER:
415419
case MLX5_CMD_OP_QUERY_FLOW_COUNTER:
416420
case MLX5_CMD_OP_ALLOC_ENCAP_HEADER:
417-
case MLX5_CMD_OP_CREATE_SCHEDULING_ELEMENT:
418-
case MLX5_CMD_OP_QUERY_SCHEDULING_ELEMENT:
419-
case MLX5_CMD_OP_MODIFY_SCHEDULING_ELEMENT:
420-
case MLX5_CMD_OP_CREATE_QOS_PARA_VPORT:
421421
*status = MLX5_DRIVER_STATUS_ABORTED;
422422
*synd = MLX5_DRIVER_SYND;
423423
return -EIO;
@@ -501,6 +501,12 @@ const char *mlx5_command_str(int command)
501501
MLX5_COMMAND_STR_CASE(QUERY_Q_COUNTER);
502502
MLX5_COMMAND_STR_CASE(SET_RATE_LIMIT);
503503
MLX5_COMMAND_STR_CASE(QUERY_RATE_LIMIT);
504+
MLX5_COMMAND_STR_CASE(CREATE_SCHEDULING_ELEMENT);
505+
MLX5_COMMAND_STR_CASE(DESTROY_SCHEDULING_ELEMENT);
506+
MLX5_COMMAND_STR_CASE(QUERY_SCHEDULING_ELEMENT);
507+
MLX5_COMMAND_STR_CASE(MODIFY_SCHEDULING_ELEMENT);
508+
MLX5_COMMAND_STR_CASE(CREATE_QOS_PARA_VPORT);
509+
MLX5_COMMAND_STR_CASE(DESTROY_QOS_PARA_VPORT);
504510
MLX5_COMMAND_STR_CASE(ALLOC_PD);
505511
MLX5_COMMAND_STR_CASE(DEALLOC_PD);
506512
MLX5_COMMAND_STR_CASE(ALLOC_UAR);
@@ -576,12 +582,6 @@ const char *mlx5_command_str(int command)
576582
MLX5_COMMAND_STR_CASE(MODIFY_FLOW_TABLE);
577583
MLX5_COMMAND_STR_CASE(ALLOC_ENCAP_HEADER);
578584
MLX5_COMMAND_STR_CASE(DEALLOC_ENCAP_HEADER);
579-
MLX5_COMMAND_STR_CASE(CREATE_SCHEDULING_ELEMENT);
580-
MLX5_COMMAND_STR_CASE(DESTROY_SCHEDULING_ELEMENT);
581-
MLX5_COMMAND_STR_CASE(QUERY_SCHEDULING_ELEMENT);
582-
MLX5_COMMAND_STR_CASE(MODIFY_SCHEDULING_ELEMENT);
583-
MLX5_COMMAND_STR_CASE(CREATE_QOS_PARA_VPORT);
584-
MLX5_COMMAND_STR_CASE(DESTROY_QOS_PARA_VPORT);
585585
default: return "unknown command opcode";
586586
}
587587
}

0 commit comments

Comments
 (0)