Skip to content

Commit a776878

Browse files
committed
Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
* 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86, efi: Calling __pa() with an ioremap()ed address is invalid x86, hpet: Immediately disable HPET timer 1 if rtc irq is masked x86/intel_mid: Kconfig select fix x86/intel_mid: Fix the Kconfig for MID selection
2 parents e2f4e0b + e8c7106 commit a776878

File tree

8 files changed

+68
-44
lines changed

8 files changed

+68
-44
lines changed

arch/x86/Kconfig

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ config X86_INTEL_CE
390390
This option compiles in support for the CE4100 SOC for settop
391391
boxes and media devices.
392392

393-
config X86_INTEL_MID
393+
config X86_WANT_INTEL_MID
394394
bool "Intel MID platform support"
395395
depends on X86_32
396396
depends on X86_EXTENDED_PLATFORM
@@ -399,7 +399,10 @@ config X86_INTEL_MID
399399
systems which do not have the PCI legacy interfaces (Moorestown,
400400
Medfield). If you are building for a PC class system say N here.
401401

402-
if X86_INTEL_MID
402+
if X86_WANT_INTEL_MID
403+
404+
config X86_INTEL_MID
405+
bool
403406

404407
config X86_MRST
405408
bool "Moorestown MID platform"
@@ -411,6 +414,7 @@ config X86_MRST
411414
select SPI
412415
select INTEL_SCU_IPC
413416
select X86_PLATFORM_DEVICES
417+
select X86_INTEL_MID
414418
---help---
415419
Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
416420
Internet Device(MID) platform. Moorestown consists of two chips:

arch/x86/include/asm/e820.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,13 @@
5353
*/
5454
#define E820_RESERVED_KERN 128
5555

56+
/*
57+
* Address ranges that need to be mapped by the kernel direct
58+
* mapping. This is used to make sure regions such as
59+
* EFI_RUNTIME_SERVICES_DATA are directly mapped. See setup_arch().
60+
*/
61+
#define E820_RESERVED_EFI 129
62+
5663
#ifndef __ASSEMBLY__
5764
#include <linux/types.h>
5865
struct e820entry {
@@ -115,6 +122,7 @@ static inline void early_memtest(unsigned long start, unsigned long end)
115122
}
116123
#endif
117124

125+
extern unsigned long e820_end_pfn(unsigned long limit_pfn, unsigned type);
118126
extern unsigned long e820_end_of_ram_pfn(void);
119127
extern unsigned long e820_end_of_low_ram_pfn(void);
120128
extern u64 early_reserve_e820(u64 startt, u64 sizet, u64 align);

arch/x86/include/asm/efi.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ extern unsigned long asmlinkage efi_call_phys(void *, ...);
3333
#define efi_call_virt6(f, a1, a2, a3, a4, a5, a6) \
3434
efi_call_virt(f, a1, a2, a3, a4, a5, a6)
3535

36-
#define efi_ioremap(addr, size, type) ioremap_cache(addr, size)
37-
3836
#else /* !CONFIG_X86_32 */
3937

4038
extern u64 efi_call0(void *fp);
@@ -84,9 +82,6 @@ extern u64 efi_call6(void *fp, u64 arg1, u64 arg2, u64 arg3,
8482
efi_call6((void *)(efi.systab->runtime->f), (u64)(a1), (u64)(a2), \
8583
(u64)(a3), (u64)(a4), (u64)(a5), (u64)(a6))
8684

87-
extern void __iomem *efi_ioremap(unsigned long addr, unsigned long size,
88-
u32 type);
89-
9085
#endif /* CONFIG_X86_32 */
9186

9287
extern int add_efi_memmap;

arch/x86/kernel/e820.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ static void __init e820_print_type(u32 type)
135135
printk(KERN_CONT "(usable)");
136136
break;
137137
case E820_RESERVED:
138+
case E820_RESERVED_EFI:
138139
printk(KERN_CONT "(reserved)");
139140
break;
140141
case E820_ACPI:
@@ -783,7 +784,7 @@ u64 __init early_reserve_e820(u64 startt, u64 sizet, u64 align)
783784
/*
784785
* Find the highest page frame number we have available
785786
*/
786-
static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type)
787+
unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type)
787788
{
788789
int i;
789790
unsigned long last_pfn = 0;

arch/x86/kernel/hpet.c

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,6 +1049,14 @@ int hpet_rtc_timer_init(void)
10491049
}
10501050
EXPORT_SYMBOL_GPL(hpet_rtc_timer_init);
10511051

1052+
static void hpet_disable_rtc_channel(void)
1053+
{
1054+
unsigned long cfg;
1055+
cfg = hpet_readl(HPET_T1_CFG);
1056+
cfg &= ~HPET_TN_ENABLE;
1057+
hpet_writel(cfg, HPET_T1_CFG);
1058+
}
1059+
10521060
/*
10531061
* The functions below are called from rtc driver.
10541062
* Return 0 if HPET is not being used.
@@ -1060,6 +1068,9 @@ int hpet_mask_rtc_irq_bit(unsigned long bit_mask)
10601068
return 0;
10611069

10621070
hpet_rtc_flags &= ~bit_mask;
1071+
if (unlikely(!hpet_rtc_flags))
1072+
hpet_disable_rtc_channel();
1073+
10631074
return 1;
10641075
}
10651076
EXPORT_SYMBOL_GPL(hpet_mask_rtc_irq_bit);
@@ -1125,15 +1136,11 @@ EXPORT_SYMBOL_GPL(hpet_rtc_dropped_irq);
11251136

11261137
static void hpet_rtc_timer_reinit(void)
11271138
{
1128-
unsigned int cfg, delta;
1139+
unsigned int delta;
11291140
int lost_ints = -1;
11301141

1131-
if (unlikely(!hpet_rtc_flags)) {
1132-
cfg = hpet_readl(HPET_T1_CFG);
1133-
cfg &= ~HPET_TN_ENABLE;
1134-
hpet_writel(cfg, HPET_T1_CFG);
1135-
return;
1136-
}
1142+
if (unlikely(!hpet_rtc_flags))
1143+
hpet_disable_rtc_channel();
11371144

11381145
if (!(hpet_rtc_flags & RTC_PIE) || hpet_pie_limit)
11391146
delta = hpet_default_delta;

arch/x86/kernel/setup.c

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,8 @@ early_param("reservelow", parse_reservelow);
691691

692692
void __init setup_arch(char **cmdline_p)
693693
{
694+
unsigned long end_pfn;
695+
694696
#ifdef CONFIG_X86_32
695697
memcpy(&boot_cpu_data, &new_cpu_data, sizeof(new_cpu_data));
696698
visws_early_detect();
@@ -932,7 +934,24 @@ void __init setup_arch(char **cmdline_p)
932934
init_gbpages();
933935

934936
/* max_pfn_mapped is updated here */
935-
max_low_pfn_mapped = init_memory_mapping(0, max_low_pfn<<PAGE_SHIFT);
937+
end_pfn = max_low_pfn;
938+
939+
#ifdef CONFIG_X86_64
940+
/*
941+
* There may be regions after the last E820_RAM region that we
942+
* want to include in the kernel direct mapping, such as
943+
* EFI_RUNTIME_SERVICES_DATA.
944+
*/
945+
if (efi_enabled) {
946+
unsigned long efi_end;
947+
948+
efi_end = e820_end_pfn(MAXMEM>>PAGE_SHIFT, E820_RESERVED_EFI);
949+
if (efi_end > max_low_pfn)
950+
end_pfn = efi_end;
951+
}
952+
#endif
953+
954+
max_low_pfn_mapped = init_memory_mapping(0, end_pfn << PAGE_SHIFT);
936955
max_pfn_mapped = max_low_pfn_mapped;
937956

938957
#ifdef CONFIG_X86_64

arch/x86/platform/efi/efi.c

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,13 @@ static void __init do_add_efi_memmap(void)
323323
case EFI_UNUSABLE_MEMORY:
324324
e820_type = E820_UNUSABLE;
325325
break;
326+
case EFI_RUNTIME_SERVICES_DATA:
327+
e820_type = E820_RESERVED_EFI;
328+
break;
326329
default:
327330
/*
328331
* EFI_RESERVED_TYPE EFI_RUNTIME_SERVICES_CODE
329-
* EFI_RUNTIME_SERVICES_DATA EFI_MEMORY_MAPPED_IO
332+
* EFI_MEMORY_MAPPED_IO
330333
* EFI_MEMORY_MAPPED_IO_PORT_SPACE EFI_PAL_CODE
331334
*/
332335
e820_type = E820_RESERVED;
@@ -671,10 +674,21 @@ void __init efi_enter_virtual_mode(void)
671674
end_pfn = PFN_UP(end);
672675
if (end_pfn <= max_low_pfn_mapped
673676
|| (end_pfn > (1UL << (32 - PAGE_SHIFT))
674-
&& end_pfn <= max_pfn_mapped))
677+
&& end_pfn <= max_pfn_mapped)) {
675678
va = __va(md->phys_addr);
676-
else
677-
va = efi_ioremap(md->phys_addr, size, md->type);
679+
680+
if (!(md->attribute & EFI_MEMORY_WB)) {
681+
addr = (u64) (unsigned long)va;
682+
npages = md->num_pages;
683+
memrange_efi_to_native(&addr, &npages);
684+
set_memory_uc(addr, npages);
685+
}
686+
} else {
687+
if (!(md->attribute & EFI_MEMORY_WB))
688+
va = ioremap_nocache(md->phys_addr, size);
689+
else
690+
va = ioremap_cache(md->phys_addr, size);
691+
}
678692

679693
md->virt_addr = (u64) (unsigned long) va;
680694

@@ -684,13 +698,6 @@ void __init efi_enter_virtual_mode(void)
684698
continue;
685699
}
686700

687-
if (!(md->attribute & EFI_MEMORY_WB)) {
688-
addr = md->virt_addr;
689-
npages = md->num_pages;
690-
memrange_efi_to_native(&addr, &npages);
691-
set_memory_uc(addr, npages);
692-
}
693-
694701
systab = (u64) (unsigned long) efi_phys.systab;
695702
if (md->phys_addr <= systab && systab < end) {
696703
systab += md->virt_addr - md->phys_addr;

arch/x86/platform/efi/efi_64.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -80,20 +80,3 @@ void __init efi_call_phys_epilog(void)
8080
local_irq_restore(efi_flags);
8181
early_code_mapping_set_exec(0);
8282
}
83-
84-
void __iomem *__init efi_ioremap(unsigned long phys_addr, unsigned long size,
85-
u32 type)
86-
{
87-
unsigned long last_map_pfn;
88-
89-
if (type == EFI_MEMORY_MAPPED_IO)
90-
return ioremap(phys_addr, size);
91-
92-
last_map_pfn = init_memory_mapping(phys_addr, phys_addr + size);
93-
if ((last_map_pfn << PAGE_SHIFT) < phys_addr + size) {
94-
unsigned long top = last_map_pfn << PAGE_SHIFT;
95-
efi_ioremap(top, size - (top - phys_addr), type);
96-
}
97-
98-
return (void __iomem *)__va(phys_addr);
99-
}

0 commit comments

Comments
 (0)