bcachefs: Do not check folio_has_private()

Matthew Wilcox (Oracle) · Kent Overstreet · commit a8cdf0ff4664 · 2024-09-09T09:41:49.000-04:00
folio_has_private() is an attractive nuisance; filesystem authors
generally don't realise that it actually checks two flags (one of which
is never set by bcachefs).  There's no need to check the private flag at
all; for folios owned by bcachefs, we know that folio-&gt;private is NULL
when the private flag is clear and non-NULL when the private flag is set.

Signed-off-by: Matthew Wilcox (Oracle) &lt;willy@infradead.org&gt;
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/fs-io-pagecache.h b/fs/bcachefs/fs-io-pagecache.h
@@ -99,9 +99,7 @@ static inline void bch2_folio_release(struct folio *folio)
 
 static inline struct bch_folio *__bch2_folio(struct folio *folio)
 {
-	return folio_has_private(folio)
-		? (struct bch_folio *) folio_get_private(folio)
-		: NULL;
+	return folio_get_private(folio);
 }
 
 static inline struct bch_folio *bch2_folio(struct folio *folio)

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,7 @@ static inline void bch2_folio_release(struct folio *folio)`
`99`	`99`
`100`	`100`	`static inline struct bch_folio __bch2_folio(struct folio folio)`
`101`	`101`	`{`
`102`		`- return folio_has_private(folio)`
`103`		`- ? (struct bch_folio *) folio_get_private(folio)`
`104`		`- : NULL;`
	`102`	`+ return folio_get_private(folio);`
`105`	`103`	`}`
`106`	`104`
`107`	`105`	`static inline struct bch_folio bch2_folio(struct folio folio)`