Skip to content

Commit a8e98f3

Browse files
fiflfomkatiwai
authored andcommitted
ALSA: ice1712: Delete unreachable code in aureon_add_controls()
If the check (id != 0x41) fails, then id == 0x41 and the other check in 'else' branch also fails: id & 0x0F = 0b01000001 & 0b00001111 = 0b00000001. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Dmitry Fomin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 951606a commit a8e98f3

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

sound/pci/ice1712/aureon.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1896,10 +1896,6 @@ static int aureon_add_controls(struct snd_ice1712 *ice)
18961896
if (id != 0x41)
18971897
dev_info(ice->card->dev,
18981898
"No CS8415 chip. Skipping CS8415 controls.\n");
1899-
else if ((id & 0x0F) != 0x01)
1900-
dev_info(ice->card->dev,
1901-
"Detected unsupported CS8415 rev. (%c)\n",
1902-
(char)((id & 0x0F) + 'A' - 1));
19031899
else {
19041900
for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
19051901
struct snd_kcontrol *kctl;

0 commit comments

Comments
 (0)