Skip to content

Commit a997762

Browse files
Johannes Thumshirngregkh
authored andcommitted
tty: serial: men_z135_uart: Wakeup UART after transmitting
Call uart_write_wakeup() after writing the hardware FIFO and updateing the FIFO pointers. This fixes high latency and jitter on PPP over Serial links. Reported-by: Jun Shih <[email protected]> Tested-by: Jun Shih <[email protected]> Signed-off-by: Johannes Thumshirn <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8b152f1 commit a997762

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/tty/serial/men_z135_uart.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -308,9 +308,6 @@ static void men_z135_handle_tx(struct men_z135_port *uart)
308308
if (port->x_char)
309309
goto out;
310310

311-
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
312-
uart_write_wakeup(port);
313-
314311
/* calculate bytes to copy */
315312
qlen = uart_circ_chars_pending(xmit);
316313
if (qlen <= 0)
@@ -357,6 +354,9 @@ static void men_z135_handle_tx(struct men_z135_port *uart)
357354

358355
port->icount.tx += n;
359356

357+
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
358+
uart_write_wakeup(port);
359+
360360
irq_en:
361361
if (!uart_circ_empty(xmit))
362362
men_z135_reg_set(uart, MEN_Z135_CONF_REG, MEN_Z135_IER_TXCIEN);

0 commit comments

Comments
 (0)