Skip to content

Commit a9c667f

Browse files
Lukas Czernertytso
authored andcommitted
ext4: fixed tracepoints cleanup
While creating fixed tracepoints for ext3, basically by porting them from ext4, I found a lot of useless retyping, wrong type usage, useless variable passing and other inconsistencies in the ext4 fixed tracepoint code. This patch cleans the fixed tracepoint code for ext4 and also simplify some of them. Signed-off-by: Lukas Czerner <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]>
1 parent c03f8aa commit a9c667f

File tree

3 files changed

+80
-107
lines changed

3 files changed

+80
-107
lines changed

fs/ext4/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2634,7 +2634,7 @@ static int ext4_writepage(struct page *page,
26342634
struct buffer_head *page_bufs = NULL;
26352635
struct inode *inode = page->mapping->host;
26362636

2637-
trace_ext4_writepage(inode, page);
2637+
trace_ext4_writepage(page);
26382638
size = i_size_read(inode);
26392639
if (page->index == size >> PAGE_CACHE_SHIFT)
26402640
len = size & ~PAGE_CACHE_MASK;

fs/ext4/mballoc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3578,8 +3578,8 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
35783578
free += next - bit;
35793579

35803580
trace_ext4_mballoc_discard(sb, NULL, group, bit, next - bit);
3581-
trace_ext4_mb_release_inode_pa(sb, pa->pa_inode, pa,
3582-
grp_blk_start + bit, next - bit);
3581+
trace_ext4_mb_release_inode_pa(pa, grp_blk_start + bit,
3582+
next - bit);
35833583
mb_free_blocks(pa->pa_inode, e4b, bit, next - bit);
35843584
bit = next + 1;
35853585
}
@@ -3608,7 +3608,7 @@ ext4_mb_release_group_pa(struct ext4_buddy *e4b,
36083608
ext4_group_t group;
36093609
ext4_grpblk_t bit;
36103610

3611-
trace_ext4_mb_release_group_pa(sb, pa);
3611+
trace_ext4_mb_release_group_pa(pa);
36123612
BUG_ON(pa->pa_deleted == 0);
36133613
ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, &bit);
36143614
BUG_ON(group != e4b->bd_group && pa->pa_len != 0);

0 commit comments

Comments
 (0)