Skip to content

Commit a9e170e

Browse files
Quinn Tranmartinkpetersen
authored andcommitted
scsi: qla2xxx: Fix uninitialized work element
Fixes following stack trace kernel: Call Trace: kernel: dump_stack+0x63/0x84 kernel: __warn+0xd1/0xf0 kernel: warn_slowpath_null+0x1d/0x20 kernel: __queue_work+0x37a/0x420 kernel: queue_work_on+0x27/0x40 kernel: queue_work+0x14/0x20 [qla2xxx] kernel: schedule_work+0x13/0x20 [qla2xxx] kernel: qla2x00_post_work+0xab/0xb0 [qla2xxx] kernel: qla2x00_post_aen_work+0x3b/0x50 [qla2xxx] kernel: qla2x00_async_event+0x20d/0x15d0 [qla2xxx] kernel: ? lock_timer_base+0x7d/0xa0 kernel: qla24xx_intr_handler+0x1da/0x310 [qla2xxx] kernel: qla2x00_poll+0x36/0x60 [qla2xxx] kernel: qla2x00_mailbox_command+0x659/0xec0 [qla2xxx] kernel: ? proc_create_data+0x7a/0xd0 kernel: qla25xx_init_rsp_que+0x15b/0x240 [qla2xxx] kernel: ? request_irq+0x14/0x20 [qla2xxx] kernel: qla25xx_create_rsp_que+0x256/0x3c0 [qla2xxx] kernel: qla2xxx_create_qpair+0x2af/0x5b0 [qla2xxx] kernel: qla2x00_probe_one+0x1107/0x1c30 [qla2xxx] Fixes: ec7193e ("qla2xxx: Fix delayed response to command for loop mode/direct connect.") Cc: <[email protected]> # 4.13 Signed-off-by: Quinn Tran <[email protected]> Signed-off-by: Himanshu Madhani <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent eef9ffd commit a9e170e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/scsi/qla2xxx/qla_os.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3175,6 +3175,8 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
31753175
host->can_queue, base_vha->req,
31763176
base_vha->mgmt_svr_loop_id, host->sg_tablesize);
31773177

3178+
INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn);
3179+
31783180
if (ha->mqenable) {
31793181
bool mq = false;
31803182
bool startit = false;
@@ -3223,7 +3225,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
32233225
*/
32243226
qla2xxx_wake_dpc(base_vha);
32253227

3226-
INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn);
32273228
INIT_WORK(&ha->board_disable, qla2x00_disable_board_on_pci_error);
32283229

32293230
if (IS_QLA8031(ha) || IS_MCTP_CAPABLE(ha)) {

0 commit comments

Comments
 (0)