fsi: scom: Fix NULL dereference

ozbenh · ozbenh · commit aa1221b2584f · 2018-08-06T12:27:04.000+10:00
The chardev conversion forgot to copy the fsi_dev, silly mistake, compounded by a testing mistake on my side, this specific driver wasn't being tested properly. Fixes: d8f4587 "fsi: scom: Convert to use the new chardev" Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
@@ -598,6 +598,7 @@ static int scom_probe(struct device *dev)
 		kfree(scom);
 		return -ENODEV;
 	}
+	scom->fsi_dev = fsi_dev;
 
 	/* Create chardev for userspace access */
 	scom->dev.type = &fsi_cdev_type;

Original file line number	Diff line number	Diff line change
`@@ -598,6 +598,7 @@ static int scom_probe(struct device *dev)`
`598`	`598`	`kfree(scom);`
`599`	`599`	`return -ENODEV;`
`600`	`600`	`}`
	`601`	`+ scom->fsi_dev = fsi_dev;`
`601`	`602`
`602`	`603`	`/* Create chardev for userspace access */`
`603`	`604`	`scom->dev.type = &fsi_cdev_type;`