Skip to content

Commit aa744cc

Browse files
matanb10dledford
authored andcommitted
IB/core: Remove smac and vlan id from qp_attr and ah_attr
Smac and vlan id could be resolved from the GID attribute, and thus these attributes aren't needed anymore. Removing them. Signed-off-by: Matan Barak <[email protected]> Reviewed-By: Devesh Sharma <[email protected]> Signed-off-by: Doug Ledford <[email protected]>
1 parent 5c266b2 commit aa744cc

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

drivers/infiniband/core/sa_query.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,11 +1029,7 @@ int ib_init_ah_from_path(struct ib_device *device, u8 port_num,
10291029
}
10301030
if (force_grh) {
10311031
memcpy(ah_attr->dmac, rec->dmac, ETH_ALEN);
1032-
ah_attr->vlan_id = rec->vlan_id;
1033-
} else {
1034-
ah_attr->vlan_id = 0xffff;
10351032
}
1036-
10371033
return 0;
10381034
}
10391035
EXPORT_SYMBOL(ib_init_ah_from_path);

drivers/infiniband/core/ucma.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1211,7 +1211,6 @@ static int ucma_set_ib_path(struct ucma_context *ctx,
12111211
return -EINVAL;
12121212

12131213
memset(&sa_path, 0, sizeof(sa_path));
1214-
sa_path.vlan_id = 0xffff;
12151214

12161215
ib_sa_unpack_path(path_data->path_rec, &sa_path);
12171216
ret = rdma_set_ib_paths(ctx->cm_id, &sa_path, 1);

drivers/infiniband/core/uverbs_cmd.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2822,7 +2822,6 @@ ssize_t ib_uverbs_create_ah(struct ib_uverbs_file *file,
28222822
attr.grh.sgid_index = cmd.attr.grh.sgid_index;
28232823
attr.grh.hop_limit = cmd.attr.grh.hop_limit;
28242824
attr.grh.traffic_class = cmd.attr.grh.traffic_class;
2825-
attr.vlan_id = 0;
28262825
memset(&attr.dmac, 0, sizeof(attr.dmac));
28272826
memcpy(attr.grh.dgid.raw, cmd.attr.grh.dgid, 16);
28282827

include/rdma/ib_verbs.h

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,6 @@ struct ib_ah_attr {
699699
u8 ah_flags;
700700
u8 port_num;
701701
u8 dmac[ETH_ALEN];
702-
u16 vlan_id;
703702
};
704703

705704
enum ib_wc_status {
@@ -958,10 +957,10 @@ enum ib_qp_attr_mask {
958957
IB_QP_PATH_MIG_STATE = (1<<18),
959958
IB_QP_CAP = (1<<19),
960959
IB_QP_DEST_QPN = (1<<20),
961-
IB_QP_SMAC = (1<<21),
962-
IB_QP_ALT_SMAC = (1<<22),
963-
IB_QP_VID = (1<<23),
964-
IB_QP_ALT_VID = (1<<24),
960+
IB_QP_RESERVED1 = (1<<21),
961+
IB_QP_RESERVED2 = (1<<22),
962+
IB_QP_RESERVED3 = (1<<23),
963+
IB_QP_RESERVED4 = (1<<24),
965964
};
966965

967966
enum ib_qp_state {
@@ -1011,10 +1010,6 @@ struct ib_qp_attr {
10111010
u8 rnr_retry;
10121011
u8 alt_port_num;
10131012
u8 alt_timeout;
1014-
u8 smac[ETH_ALEN];
1015-
u8 alt_smac[ETH_ALEN];
1016-
u16 vlan_id;
1017-
u16 alt_vlan_id;
10181013
};
10191014

10201015
enum ib_wr_opcode {

0 commit comments

Comments
 (0)