Skip to content

Commit aa90294

Browse files
tlfalcondavem330
authored andcommitted
ibmvnic: Fix TX descriptor tracking
With the recent change, transmissions that only needed one descriptor were being missed. The result is that such packets were tracked as outstanding transmissions but never removed when its completion notification was received. Fixes: ffc385b ("ibmvnic: Keep track of supplementary TX descriptors") Signed-off-by: Thomas Falcon <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f4af1db commit aa90294

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/ibm/ibmvnic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1478,7 +1478,6 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
14781478
if ((*hdrs >> 7) & 1) {
14791479
build_hdr_descs_arr(tx_buff, &num_entries, *hdrs);
14801480
tx_crq.v1.n_crq_elem = num_entries;
1481-
tx_buff->num_entries = num_entries;
14821481
tx_buff->indir_arr[0] = tx_crq;
14831482
tx_buff->indir_dma = dma_map_single(dev, tx_buff->indir_arr,
14841483
sizeof(tx_buff->indir_arr),
@@ -1533,6 +1532,7 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
15331532
netif_stop_subqueue(netdev, queue_num);
15341533
}
15351534

1535+
tx_buff->num_entries = num_entries;
15361536
tx_packets++;
15371537
tx_bytes += skb->len;
15381538
txq->trans_start = jiffies;

0 commit comments

Comments
 (0)