Skip to content

Commit aa9d6e0

Browse files
shemmingerdavem330
authored andcommitted
linux/netlink.h: drop unnecessary extern prefix
Don't need extern prefix before function prototypes. Checkpatch has complained about this for a couple of years. Signed-off-by: Stephen Hemminger <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7de3330 commit aa9d6e0

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

include/linux/netlink.h

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ struct netlink_skb_parms {
3434
#define NETLINK_CREDS(skb) (&NETLINK_CB((skb)).creds)
3535

3636

37-
extern void netlink_table_grab(void);
38-
extern void netlink_table_ungrab(void);
37+
void netlink_table_grab(void);
38+
void netlink_table_ungrab(void);
3939

4040
#define NL_CFG_F_NONROOT_RECV (1 << 0)
4141
#define NL_CFG_F_NONROOT_SEND (1 << 1)
@@ -51,7 +51,7 @@ struct netlink_kernel_cfg {
5151
bool (*compare)(struct net *net, struct sock *sk);
5252
};
5353

54-
extern struct sock *__netlink_kernel_create(struct net *net, int unit,
54+
struct sock *__netlink_kernel_create(struct net *net, int unit,
5555
struct module *module,
5656
struct netlink_kernel_cfg *cfg);
5757
static inline struct sock *
@@ -119,24 +119,24 @@ static inline void nl_set_extack_cookie_u64(struct netlink_ext_ack *extack,
119119
extack->cookie_len = sizeof(__cookie);
120120
}
121121

122-
extern void netlink_kernel_release(struct sock *sk);
123-
extern int __netlink_change_ngroups(struct sock *sk, unsigned int groups);
124-
extern int netlink_change_ngroups(struct sock *sk, unsigned int groups);
125-
extern void __netlink_clear_multicast_users(struct sock *sk, unsigned int group);
126-
extern void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err,
127-
const struct netlink_ext_ack *extack);
128-
extern int netlink_has_listeners(struct sock *sk, unsigned int group);
129-
130-
extern int netlink_unicast(struct sock *ssk, struct sk_buff *skb, __u32 portid, int nonblock);
131-
extern int netlink_broadcast(struct sock *ssk, struct sk_buff *skb, __u32 portid,
132-
__u32 group, gfp_t allocation);
133-
extern int netlink_broadcast_filtered(struct sock *ssk, struct sk_buff *skb,
134-
__u32 portid, __u32 group, gfp_t allocation,
135-
int (*filter)(struct sock *dsk, struct sk_buff *skb, void *data),
136-
void *filter_data);
137-
extern int netlink_set_err(struct sock *ssk, __u32 portid, __u32 group, int code);
138-
extern int netlink_register_notifier(struct notifier_block *nb);
139-
extern int netlink_unregister_notifier(struct notifier_block *nb);
122+
void netlink_kernel_release(struct sock *sk);
123+
int __netlink_change_ngroups(struct sock *sk, unsigned int groups);
124+
int netlink_change_ngroups(struct sock *sk, unsigned int groups);
125+
void __netlink_clear_multicast_users(struct sock *sk, unsigned int group);
126+
void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err,
127+
const struct netlink_ext_ack *extack);
128+
int netlink_has_listeners(struct sock *sk, unsigned int group);
129+
130+
int netlink_unicast(struct sock *ssk, struct sk_buff *skb, __u32 portid, int nonblock);
131+
int netlink_broadcast(struct sock *ssk, struct sk_buff *skb, __u32 portid,
132+
__u32 group, gfp_t allocation);
133+
int netlink_broadcast_filtered(struct sock *ssk, struct sk_buff *skb,
134+
__u32 portid, __u32 group, gfp_t allocation,
135+
int (*filter)(struct sock *dsk, struct sk_buff *skb, void *data),
136+
void *filter_data);
137+
int netlink_set_err(struct sock *ssk, __u32 portid, __u32 group, int code);
138+
int netlink_register_notifier(struct notifier_block *nb);
139+
int netlink_unregister_notifier(struct notifier_block *nb);
140140

141141
/* finegrained unicast helpers: */
142142
struct sock *netlink_getsockbyfilp(struct file *filp);
@@ -212,7 +212,7 @@ struct netlink_dump_control {
212212
u16 min_dump_alloc;
213213
};
214214

215-
extern int __netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
215+
int __netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
216216
const struct nlmsghdr *nlh,
217217
struct netlink_dump_control *control);
218218
static inline int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
@@ -231,8 +231,8 @@ struct netlink_tap {
231231
struct list_head list;
232232
};
233233

234-
extern int netlink_add_tap(struct netlink_tap *nt);
235-
extern int netlink_remove_tap(struct netlink_tap *nt);
234+
int netlink_add_tap(struct netlink_tap *nt);
235+
int netlink_remove_tap(struct netlink_tap *nt);
236236

237237
bool __netlink_ns_capable(const struct netlink_skb_parms *nsp,
238238
struct user_namespace *ns, int cap);

0 commit comments

Comments
 (0)