Skip to content

Commit abd4e74

Browse files
robherringatseanpaul
authored andcommitted
Revert "drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset()"
This reverts commit 220df83. Turns out drm_gem_dumb_map_offset really only worked for the dumb buffer case, so revert the name change. Signed-off-by: Rob Herring <[email protected]> Signed-off-by: Sean Paul <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent e6be0a9 commit abd4e74

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

drivers/gpu/drm/drm_dumb_buffers.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
* To support dumb objects drivers must implement the &drm_driver.dumb_create
4949
* operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy() if
5050
* not set and &drm_driver.dumb_map_offset defaults to
51-
* drm_gem_map_offset(). See the callbacks for further details.
51+
* drm_gem_dumb_map_offset(). See the callbacks for further details.
5252
*
5353
* Note that dumb objects may not be used for gpu acceleration, as has been
5454
* attempted on some ARM embedded platforms. Such drivers really must have
@@ -127,7 +127,7 @@ int drm_mode_mmap_dumb_ioctl(struct drm_device *dev,
127127
args->handle,
128128
&args->offset);
129129
else
130-
return drm_gem_map_offset(file_priv, dev, args->handle,
130+
return drm_gem_dumb_map_offset(file_priv, dev, args->handle,
131131
&args->offset);
132132
}
133133

drivers/gpu/drm/drm_gem.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle)
298298
EXPORT_SYMBOL(drm_gem_handle_delete);
299299

300300
/**
301-
* drm_gem_map_offset - return the fake mmap offset for a gem object
301+
* drm_gem_dumb_map_offset - return the fake mmap offset for a gem object
302302
* @file: drm file-private structure containing the gem object
303303
* @dev: corresponding drm_device
304304
* @handle: gem object handle
@@ -307,14 +307,10 @@ EXPORT_SYMBOL(drm_gem_handle_delete);
307307
* This implements the &drm_driver.dumb_map_offset kms driver callback for
308308
* drivers which use gem to manage their backing storage.
309309
*
310-
* It can also be used by drivers using GEM BO implementations which
311-
* have same restriction that imported objects cannot be mapped. The
312-
* shmem backend is one example.
313-
*
314310
* Returns:
315311
* 0 on success or a negative error code on failure.
316312
*/
317-
int drm_gem_map_offset(struct drm_file *file, struct drm_device *dev,
313+
int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
318314
u32 handle, u64 *offset)
319315
{
320316
struct drm_gem_object *obj;
@@ -340,7 +336,7 @@ int drm_gem_map_offset(struct drm_file *file, struct drm_device *dev,
340336

341337
return ret;
342338
}
343-
EXPORT_SYMBOL_GPL(drm_gem_map_offset);
339+
EXPORT_SYMBOL_GPL(drm_gem_dumb_map_offset);
344340

345341
/**
346342
* drm_gem_dumb_destroy - dumb fb callback helper for gem based drivers

drivers/gpu/drm/exynos/exynos_drm_gem.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,8 @@ int exynos_drm_gem_map_ioctl(struct drm_device *dev, void *data,
273273
{
274274
struct drm_exynos_gem_map *args = data;
275275

276-
return drm_gem_map_offset(file_priv, dev, args->handle, &args->offset);
276+
return drm_gem_dumb_map_offset(file_priv, dev, args->handle,
277+
&args->offset);
277278
}
278279

279280
struct exynos_drm_gem *exynos_drm_gem_get(struct drm_file *filp,

include/drm/drm_gem.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,8 @@ int drm_gem_fence_array_add(struct xarray *fence_array,
401401
int drm_gem_fence_array_add_implicit(struct xarray *fence_array,
402402
struct drm_gem_object *obj,
403403
bool write);
404-
int drm_gem_map_offset(struct drm_file *file, struct drm_device *dev,
405-
u32 handle, u64 *offset);
404+
int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
405+
u32 handle, u64 *offset);
406406
int drm_gem_dumb_destroy(struct drm_file *file,
407407
struct drm_device *dev,
408408
uint32_t handle);

0 commit comments

Comments
 (0)