media: Staging: media: atomisp: Use kcalloc instead of kzalloc

srishti9612 · mchehab · commit abe513924879 · 2017-09-23T15:09:01.000-04:00
Use kcalloc instead of kzalloc to check for an overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtishar@gmail.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
@@ -235,7 +235,9 @@ sh_css_load_firmware(const char *fw_data,
 		sh_css_blob_info = NULL;
 	}
 
-	fw_minibuffer = kzalloc(sh_css_num_binaries * sizeof(struct fw_param), GFP_KERNEL);
+	fw_minibuffer = kcalloc(sh_css_num_binaries, sizeof(struct fw_param),
+				GFP_KERNEL);
+
 	if (fw_minibuffer == NULL)
 		return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
 

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,9 @@ sh_css_load_firmware(const char *fw_data,`
`235`	`235`	`sh_css_blob_info = NULL;`
`236`	`236`	`}`
`237`	`237`
`238`		`- fw_minibuffer = kzalloc(sh_css_num_binaries * sizeof(struct fw_param), GFP_KERNEL);`
	`238`	`+ fw_minibuffer = kcalloc(sh_css_num_binaries, sizeof(struct fw_param),`
	`239`	`+ GFP_KERNEL);`
	`240`	`+`
`239`	`241`	`if (fw_minibuffer == NULL)`
`240`	`242`	`return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;`
`241`	`243`