Skip to content

Commit ac56506

Browse files
arndbdavem330
authored andcommitted
isdn: eicon: fix old-style declarations
Modern C standards expect the '__inline__' keyword to come before the return type in a declaration, and we get many warnings for this with "make W=1" because the eicon driver has this in a header file: eicon/divasmain.c:448:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/divasmain.c:453:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/divasmain.c:458:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/divasmain.c:463:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/divasmain.c:468:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/divasmain.c:473:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/platform.h:274:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] eicon/platform.h:280:1: error: '__inline__' is not at beginning of declaration [-Werror=old-style-declaration] A similar warning gets printed for the diva_os_register_io_port() declaration, because 'register' is interpreted as a keyword instead of a variable name: In file included from eicon/diva_didd.c:21:0: eicon/platform.h:206:1: error: 'register' is not at beginning of declaration [-Werror=old-style-declaration] Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 60a25d0 commit ac56506

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

drivers/isdn/hardware/eicon/divasmain.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -445,32 +445,32 @@ void divasa_unmap_pci_bar(void __iomem *bar)
445445
/*********************************************************
446446
** I/O port access
447447
*********************************************************/
448-
byte __inline__ inpp(void __iomem *addr)
448+
inline byte inpp(void __iomem *addr)
449449
{
450450
return (inb((unsigned long) addr));
451451
}
452452

453-
word __inline__ inppw(void __iomem *addr)
453+
inline word inppw(void __iomem *addr)
454454
{
455455
return (inw((unsigned long) addr));
456456
}
457457

458-
void __inline__ inppw_buffer(void __iomem *addr, void *P, int length)
458+
inline void inppw_buffer(void __iomem *addr, void *P, int length)
459459
{
460460
insw((unsigned long) addr, (word *) P, length >> 1);
461461
}
462462

463-
void __inline__ outppw_buffer(void __iomem *addr, void *P, int length)
463+
inline void outppw_buffer(void __iomem *addr, void *P, int length)
464464
{
465465
outsw((unsigned long) addr, (word *) P, length >> 1);
466466
}
467467

468-
void __inline__ outppw(void __iomem *addr, word w)
468+
inline void outppw(void __iomem *addr, word w)
469469
{
470470
outw(w, (unsigned long) addr);
471471
}
472472

473-
void __inline__ outpp(void __iomem *addr, word p)
473+
inline void outpp(void __iomem *addr, word p)
474474
{
475475
outb(p, (unsigned long) addr);
476476
}

drivers/isdn/hardware/eicon/platform.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ void PCIread(byte bus, byte func, int offset, void *data, int length, void *pci_
203203
/*
204204
** I/O Port utilities
205205
*/
206-
int diva_os_register_io_port(void *adapter, int register, unsigned long port,
206+
int diva_os_register_io_port(void *adapter, int reg, unsigned long port,
207207
unsigned long length, const char *name, int id);
208208
/*
209209
** I/O port access abstraction
@@ -271,13 +271,13 @@ void diva_os_get_time(dword *sec, dword *usec);
271271
** atomic operation, fake because we use threads
272272
*/
273273
typedef int diva_os_atomic_t;
274-
static diva_os_atomic_t __inline__
274+
static inline diva_os_atomic_t
275275
diva_os_atomic_increment(diva_os_atomic_t *pv)
276276
{
277277
*pv += 1;
278278
return (*pv);
279279
}
280-
static diva_os_atomic_t __inline__
280+
static inline diva_os_atomic_t
281281
diva_os_atomic_decrement(diva_os_atomic_t *pv)
282282
{
283283
*pv -= 1;

0 commit comments

Comments
 (0)