gspca: Fix falling back to lower isoc alt settings

Mauro Carvalho Chehab · torvalds · commit ac97ecc88647 · 2011-12-31T11:53:58.000-08:00
The current gspca core code has a regression where it no longer properly
falls back to lower alt settings when there is not enough bandwidth.

This causes many iso based usb-1 cameras to not work when plugged into a
usb2 hub or a sandybridge chipset motherboard!

This patch fixes this.

Signed-off-by: Hans de Goede &lt;hdegoede@redhat.com&gt;
Signed-off-by: Mauro Carvalho Chehab &lt;mchehab@redhat.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
@@ -957,7 +957,7 @@ static int gspca_init_transfer(struct gspca_dev *gspca_dev)
 				ret = -EIO;
 				goto out;
 			}
-			alt = ep_tb[--alt_idx].alt;
+			gspca_dev->alt = ep_tb[--alt_idx].alt;
 		}
 	}
 out:

Original file line number	Diff line number	Diff line change
`@@ -957,7 +957,7 @@ static int gspca_init_transfer(struct gspca_dev *gspca_dev)`
`957`	`957`	`ret = -EIO;`
`958`	`958`	`goto out;`
`959`	`959`	`}`
`960`		`- alt = ep_tb[--alt_idx].alt;`
	`960`	`+ gspca_dev->alt = ep_tb[--alt_idx].alt;`
`961`	`961`	`}`
`962`	`962`	`}`
`963`	`963`	`out:`