Skip to content

Commit add0c59

Browse files
committed
cgroup: remove bcache_subsys_id which got added stealthily
cafe563 ("bcache: A block layer cache") added a new cgroup subsystem bcache_subsys without proper review and ack. bcache_subsys seems to use cgroup for group stats and per-group cache_mode configuration. This is very much the type of usage that we don't want to allow. Fortunately, CONFIG_CGROUP_BCACHE which enables bcache_subsys is currently commented out, so this shouldn't have any upstream users. Let's nip in the bud. While at it, clarify in cgroup_subsys.h that no new subsystem should be added without explicit acks from cgroup maintainers. Signed-off-by: Tejun Heo <[email protected]> Cc: Li Zefan <[email protected]> Cc: [email protected] Cc: Kent Overstreet <[email protected]> Cc: Jens Axboe <[email protected]> Cc: [email protected]
1 parent a82a729 commit add0c59

File tree

1 file changed

+7
-38
lines changed

1 file changed

+7
-38
lines changed

include/linux/cgroup_subsys.h

Lines changed: 7 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,86 +1,55 @@
1-
/* Add subsystem definitions of the form SUBSYS(<name>) in this
2-
* file. Surround each one by a line of comment markers so that
3-
* patches don't collide
1+
/*
2+
* List of cgroup subsystems.
3+
*
4+
* DO NOT ADD ANY SUBSYSTEM WITHOUT EXPLICIT ACKS FROM CGROUP MAINTAINERS.
45
*/
5-
6-
/* */
7-
8-
/* */
9-
106
#if IS_SUBSYS_ENABLED(CONFIG_CPUSETS)
117
SUBSYS(cpuset)
128
#endif
139

14-
/* */
15-
1610
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEBUG)
1711
SUBSYS(debug)
1812
#endif
1913

20-
/* */
21-
2214
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_SCHED)
2315
SUBSYS(cpu_cgroup)
2416
#endif
2517

26-
/* */
27-
2818
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_CPUACCT)
2919
SUBSYS(cpuacct)
3020
#endif
3121

32-
/* */
33-
3422
#if IS_SUBSYS_ENABLED(CONFIG_MEMCG)
3523
SUBSYS(mem_cgroup)
3624
#endif
3725

38-
/* */
39-
4026
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_DEVICE)
4127
SUBSYS(devices)
4228
#endif
4329

44-
/* */
45-
4630
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_FREEZER)
4731
SUBSYS(freezer)
4832
#endif
4933

50-
/* */
51-
5234
#if IS_SUBSYS_ENABLED(CONFIG_NET_CLS_CGROUP)
5335
SUBSYS(net_cls)
5436
#endif
5537

56-
/* */
57-
5838
#if IS_SUBSYS_ENABLED(CONFIG_BLK_CGROUP)
5939
SUBSYS(blkio)
6040
#endif
6141

62-
/* */
63-
6442
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_PERF)
6543
SUBSYS(perf)
6644
#endif
6745

68-
/* */
69-
7046
#if IS_SUBSYS_ENABLED(CONFIG_NETPRIO_CGROUP)
7147
SUBSYS(net_prio)
7248
#endif
7349

74-
/* */
75-
7650
#if IS_SUBSYS_ENABLED(CONFIG_CGROUP_HUGETLB)
7751
SUBSYS(hugetlb)
7852
#endif
79-
80-
/* */
81-
82-
#ifdef CONFIG_CGROUP_BCACHE
83-
SUBSYS(bcache)
84-
#endif
85-
86-
/* */
53+
/*
54+
* DO NOT ADD ANY SUBSYSTEM WITHOUT EXPLICIT ACKS FROM CGROUP MAINTAINERS.
55+
*/

0 commit comments

Comments
 (0)