Skip to content

Commit ae99286

Browse files
KAGA-KOKOThomas Gleixner
authored andcommitted
nohz: disable tick_nohz_kick_tick() for now
Impact: nohz powersavings and wakeup regression commit fb02fbc (NOHZ: restart tick device from irq_enter()) causes a serious wakeup regression. While the patch is correct it does not take into account that spurious wakeups happen on x86. A fix for this issue is available, but we just revert to the .27 behaviour and let long running softirqs screw themself. Disable it for now. Signed-off-by: Thomas Gleixner <[email protected]>
1 parent ee5f80a commit ae99286

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

kernel/time/tick-sched.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,9 @@ static void tick_nohz_switch_to_nohz(void)
568568
*/
569569
static void tick_nohz_kick_tick(int cpu)
570570
{
571+
#if 0
572+
/* Switch back to 2.6.27 behaviour */
573+
571574
struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
572575
ktime_t delta, now;
573576

@@ -584,6 +587,7 @@ static void tick_nohz_kick_tick(int cpu)
584587
return;
585588

586589
tick_nohz_restart(ts, now);
590+
#endif
587591
}
588592

589593
#else

0 commit comments

Comments
 (0)