cifs: fix wrong unlock before return from cifs_tree_connect()

Yang Yingliang · Steve French · commit aea02fc40a7f · 2022-08-01T01:34:45.000-05:00
It should unlock 'tcon-&gt;tc_lock' before return from cifs_tree_connect().

Fixes: fe67bd563ec2 ("cifs: avoid use of global locks for high contention data")
Signed-off-by: Yang Yingliang &lt;yangyingliang@huawei.com&gt;
Reviewed-by: Shyam Prasad N &lt;sprasad@microsoft.com&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
@@ -4583,7 +4583,7 @@ int cifs_tree_connect(const unsigned int xid, struct cifs_tcon *tcon, const stru
 	if (tcon->ses->ses_status != SES_GOOD ||
 	    (tcon->status != TID_NEW &&
 	    tcon->status != TID_NEED_TCON)) {
-		spin_unlock(&tcon->ses->ses_lock);
+		spin_unlock(&tcon->tc_lock);
 		return 0;
 	}
 	tcon->status = TID_IN_TCON;

Original file line number	Diff line number	Diff line change
`@@ -4583,7 +4583,7 @@ int cifs_tree_connect(const unsigned int xid, struct cifs_tcon *tcon, const stru`
`4583`	`4583`	`if (tcon->ses->ses_status != SES_GOOD \|\|`
`4584`	`4584`	`(tcon->status != TID_NEW &&`
`4585`	`4585`	`tcon->status != TID_NEED_TCON)) {`
`4586`		`- spin_unlock(&tcon->ses->ses_lock);`
	`4586`	`+ spin_unlock(&tcon->tc_lock);`
`4587`	`4587`	`return 0;`
`4588`	`4588`	`}`
`4589`	`4589`	`tcon->status = TID_IN_TCON;`