Skip to content

Commit b10effb

Browse files
aneftinJeff Kirsher
authored andcommitted
e1000e: fix buffer overrun while the I219 is processing DMA transactions
Intel® 100/200 Series Chipset platforms reduced the round-trip latency for the LAN Controller DMA accesses, causing in some high performance cases a buffer overrun while the I219 LAN Connected Device is processing the DMA transactions. I219LM and I219V devices can fall into unrecovered Tx hang under very stressfully UDP traffic and multiple reconnection of Ethernet cable. This Tx hang of the LAN Controller is only recovered if the system is rebooted. Slightly slow down DMA access by reducing the number of outstanding requests. This workaround could have an impact on TCP traffic performance on the platform. Disabling TSO eliminates performance loss for TCP traffic without a noticeable impact on CPU performance. Please, refer to I218/I219 specification update: https://www.intel.com/content/www/us/en/embedded/products/networking/ ethernet-connection-i218-family-documentation.html Signed-off-by: Sasha Neftin <[email protected]> Reviewed-by: Dima Ruinskiy <[email protected]> Reviewed-by: Raanan Avargil <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 4aea7a5 commit b10effb

File tree

1 file changed

+5
-3
lines changed
  • drivers/net/ethernet/intel/e1000e

1 file changed

+5
-3
lines changed

drivers/net/ethernet/intel/e1000e/netdev.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3021,16 +3021,18 @@ static void e1000_configure_tx(struct e1000_adapter *adapter)
30213021

30223022
hw->mac.ops.config_collision_dist(hw);
30233023

3024-
/* SPT and CNP Si errata workaround to avoid data corruption */
3025-
if (hw->mac.type >= e1000_pch_spt) {
3024+
/* SPT and KBL Si errata workaround to avoid data corruption */
3025+
if (hw->mac.type == e1000_pch_spt) {
30263026
u32 reg_val;
30273027

30283028
reg_val = er32(IOSFPC);
30293029
reg_val |= E1000_RCTL_RDMTS_HEX;
30303030
ew32(IOSFPC, reg_val);
30313031

30323032
reg_val = er32(TARC(0));
3033-
reg_val |= E1000_TARC0_CB_MULTIQ_3_REQ;
3033+
/* SPT and KBL Si errata workaround to avoid Tx hang */
3034+
reg_val &= ~BIT(28);
3035+
reg_val |= BIT(29);
30343036
ew32(TARC(0), reg_val);
30353037
}
30363038
}

0 commit comments

Comments
 (0)