Skip to content

Commit b14ed2c

Browse files
richardweinbergerIngo Molnar
authored andcommitted
sched: Fix sched_policy < 0 comparison
attr.sched_policy is u32, therefore a comparison against < 0 is never true. Fix this by casting sched_policy to int. This issue was reported by coverity CID 1219934. Fixes: dbdb227 ("sched: Disallow sched_attr::sched_policy < 0") Signed-off-by: Richard Weinberger <[email protected]> Signed-off-by: Peter Zijlstra <[email protected]> Cc: Michael Kerrisk <[email protected]> Cc: Linus Torvalds <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
1 parent e9dd685 commit b14ed2c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/sched/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3685,7 +3685,7 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,
36853685
if (retval)
36863686
return retval;
36873687

3688-
if (attr.sched_policy < 0)
3688+
if ((int)attr.sched_policy < 0)
36893689
return -EINVAL;
36903690

36913691
rcu_read_lock();

0 commit comments

Comments
 (0)