ipvlan: Remove a useless comparison

YueHaibing · davem330 · commit b1dd054dbb72 · 2018-12-10T11:55:05.000-08:00
Fix following gcc warning:

drivers/net/ipvlan/ipvlan_main.c:543:12: warning:
 comparison is always false due to limited range of data type [-Wtype-limits]

'mode' is a u16 variable, IPVLAN_MODE_L2 is zero,
the comparison is always false

Signed-off-by: YueHaibing &lt;yuehaibing@huawei.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
@@ -540,7 +540,7 @@ static int ipvlan_nl_validate(struct nlattr *tb[], struct nlattr *data[],
 	if (data[IFLA_IPVLAN_MODE]) {
 		u16 mode = nla_get_u16(data[IFLA_IPVLAN_MODE]);
 
-		if (mode < IPVLAN_MODE_L2 || mode >= IPVLAN_MODE_MAX)
+		if (mode >= IPVLAN_MODE_MAX)
 			return -EINVAL;
 	}
 	if (data[IFLA_IPVLAN_FLAGS]) {

Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ static int ipvlan_nl_validate(struct nlattr tb[], struct nlattr data[],`
`540`	`540`	`if (data[IFLA_IPVLAN_MODE]) {`
`541`	`541`	`u16 mode = nla_get_u16(data[IFLA_IPVLAN_MODE]);`
`542`	`542`
`543`		`- if (mode < IPVLAN_MODE_L2 \|\| mode >= IPVLAN_MODE_MAX)`
	`543`	`+ if (mode >= IPVLAN_MODE_MAX)`
`544`	`544`	`return -EINVAL;`
`545`	`545`	`}`
`546`	`546`	`if (data[IFLA_IPVLAN_FLAGS]) {`