Skip to content

Commit b1e952b

Browse files
chazyMarc Zyngier
authored andcommitted
arm/arm64: vgic: Remove unreachable irq_clear_pending
When 'injecting' an edge-triggered interrupt with a falling edge we shouldn't clear the pending state on the distributor. In fact, we don't, because the check in vgic_validate_injection would prevent us from ever reaching this bit of code. Remove the unreachable snippet. Signed-off-by: Christoffer Dall <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent 5100f98 commit b1e952b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

virt/kvm/arm/vgic.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,8 +1643,6 @@ static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid,
16431643
vgic_dist_irq_clear_level(vcpu, irq_num);
16441644
if (!vgic_dist_irq_soft_pend(vcpu, irq_num))
16451645
vgic_dist_irq_clear_pending(vcpu, irq_num);
1646-
} else {
1647-
vgic_dist_irq_clear_pending(vcpu, irq_num);
16481646
}
16491647

16501648
ret = false;

0 commit comments

Comments
 (0)