Skip to content

Commit b2d3907

Browse files
author
Saeed Mahameed
committed
net/mlx5: Eliminate query xsrq dead code
1. This function is not used anywhere in mlx5 driver 2. It has a memcpy statement that makes no sense and produces build warning with gcc8 drivers/net/ethernet/mellanox/mlx5/core/transobj.c: In function 'mlx5_core_query_xsrq': drivers/net/ethernet/mellanox/mlx5/core/transobj.c:347:3: error: 'memcpy' source argument is the same as destination [-Werror=restrict] Fixes: 01949d0 ("net/mlx5_core: Enable XRCs and SRQs when using ISSI > 0") Reported-by: Arnd Bergmann <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 7b2117b commit b2d3907

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

drivers/net/ethernet/mellanox/mlx5/core/transobj.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -354,27 +354,6 @@ int mlx5_core_destroy_xsrq(struct mlx5_core_dev *dev, u32 xsrqn)
354354
return mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
355355
}
356356

357-
int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u32 *out)
358-
{
359-
u32 in[MLX5_ST_SZ_DW(query_xrc_srq_in)] = {0};
360-
void *srqc;
361-
void *xrc_srqc;
362-
int err;
363-
364-
MLX5_SET(query_xrc_srq_in, in, opcode, MLX5_CMD_OP_QUERY_XRC_SRQ);
365-
MLX5_SET(query_xrc_srq_in, in, xrc_srqn, xsrqn);
366-
err = mlx5_cmd_exec(dev, in, sizeof(in), out,
367-
MLX5_ST_SZ_BYTES(query_xrc_srq_out));
368-
if (!err) {
369-
xrc_srqc = MLX5_ADDR_OF(query_xrc_srq_out, out,
370-
xrc_srq_context_entry);
371-
srqc = MLX5_ADDR_OF(query_srq_out, out, srq_context_entry);
372-
memcpy(srqc, xrc_srqc, MLX5_ST_SZ_BYTES(srqc));
373-
}
374-
375-
return err;
376-
}
377-
378357
int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u16 lwm)
379358
{
380359
u32 in[MLX5_ST_SZ_DW(arm_xrc_srq_in)] = {0};

include/linux/mlx5/transobj.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ int mlx5_core_arm_rmp(struct mlx5_core_dev *dev, u32 rmpn, u16 lwm);
6767
int mlx5_core_create_xsrq(struct mlx5_core_dev *dev, u32 *in, int inlen,
6868
u32 *rmpn);
6969
int mlx5_core_destroy_xsrq(struct mlx5_core_dev *dev, u32 rmpn);
70-
int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u32 *out);
7170
int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u16 lwm);
7271

7372
int mlx5_core_create_rqt(struct mlx5_core_dev *dev, u32 *in, int inlen,

0 commit comments

Comments
 (0)