Skip to content

Commit b2d4586

Browse files
Mike Christieaxboe
authored andcommitted
nilfs: use bio op accessors
Separate the op from the rq_flag_bits and have nilfs set/get the bio using bio_set_op_attrs/bio_op. Signed-off-by: Mike Christie <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Acked-by: Ryusuke Konishi <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent eed25cd commit b2d4586

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

fs/nilfs2/segbuf.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ static void nilfs_end_bio_write(struct bio *bio)
346346
}
347347

348348
static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
349-
struct nilfs_write_info *wi, int mode)
349+
struct nilfs_write_info *wi, int mode,
350+
int mode_flags)
350351
{
351352
struct bio *bio = wi->bio;
352353
int err;
@@ -364,7 +365,7 @@ static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
364365

365366
bio->bi_end_io = nilfs_end_bio_write;
366367
bio->bi_private = segbuf;
367-
bio->bi_rw = mode;
368+
bio_set_op_attrs(bio, mode, mode_flags);
368369
submit_bio(bio);
369370
segbuf->sb_nbio++;
370371

@@ -438,7 +439,7 @@ static int nilfs_segbuf_submit_bh(struct nilfs_segment_buffer *segbuf,
438439
return 0;
439440
}
440441
/* bio is FULL */
441-
err = nilfs_segbuf_submit_bio(segbuf, wi, mode);
442+
err = nilfs_segbuf_submit_bio(segbuf, wi, mode, 0);
442443
/* never submit current bh */
443444
if (likely(!err))
444445
goto repeat;
@@ -462,19 +463,19 @@ static int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf,
462463
{
463464
struct nilfs_write_info wi;
464465
struct buffer_head *bh;
465-
int res = 0, rw = WRITE;
466+
int res = 0;
466467

467468
wi.nilfs = nilfs;
468469
nilfs_segbuf_prepare_write(segbuf, &wi);
469470

470471
list_for_each_entry(bh, &segbuf->sb_segsum_buffers, b_assoc_buffers) {
471-
res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, rw);
472+
res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, REQ_OP_WRITE);
472473
if (unlikely(res))
473474
goto failed_bio;
474475
}
475476

476477
list_for_each_entry(bh, &segbuf->sb_payload_buffers, b_assoc_buffers) {
477-
res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, rw);
478+
res = nilfs_segbuf_submit_bh(segbuf, &wi, bh, REQ_OP_WRITE);
478479
if (unlikely(res))
479480
goto failed_bio;
480481
}
@@ -484,8 +485,8 @@ static int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf,
484485
* Last BIO is always sent through the following
485486
* submission.
486487
*/
487-
rw |= REQ_SYNC;
488-
res = nilfs_segbuf_submit_bio(segbuf, &wi, rw);
488+
res = nilfs_segbuf_submit_bio(segbuf, &wi, REQ_OP_WRITE,
489+
REQ_SYNC);
489490
}
490491

491492
failed_bio:

0 commit comments

Comments
 (0)