Skip to content

Commit b36ed73

Browse files
ipoib: supress the retry related completion errors
IPoIB doesn't support transport/rnr retry schemes as per RFC so those errors are expected. No need to flood the log files with them. It was tempting make it as upstream(debug mode only) but since we have this erros in Oracle IB stack for while, leaving rest of them to be logged. Orabug: 24663803, 22347191 Tested-by: Michael Nowak <[email protected]> Tested-by: Rafael Alejandro Peralez <[email protected]> Tested-by: Liwen Huang <[email protected]> Tested-by: Hong Liu <[email protected]> Reviewed-by: Mukesh Kacker <[email protected]> Reported-by: Rajiv Raja <[email protected]> Signed-off-by: Santosh Shilimkar <[email protected]>
1 parent dde2689 commit b36ed73

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

drivers/infiniband/ulp/ipoib/ipoib_cm.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -918,13 +918,16 @@ void ipoib_cm_handle_tx_wc(struct net_device *dev, struct ib_wc *wc)
918918
wc->status != IB_WC_WR_FLUSH_ERR) {
919919
struct ipoib_neigh *neigh;
920920

921-
/*IB_WC_RNR_RETRY_EXC_ERR error is part of the life cycle, so don't make waves.*/
922-
if (IB_WC_RNR_RETRY_EXC_ERR != wc->status)
923-
ipoib_warn(priv, "%s: failed cm send event "
921+
/* IB_WC[_RNR]_RETRY_EXC_ERR error is part of the life cycle,
922+
* so don't make waves.
923+
*/
924+
if (IB_WC_RNR_RETRY_EXC_ERR == wc->status ||
925+
IB_WC_RETRY_EXC_ERR == wc->status)
926+
ipoib_dbg(priv, "%s: failed cm send event "
924927
"(status=%d, wrid=%d vend_err 0x%x)\n",
925928
__func__, wc->status, wr_id, wc->vendor_err);
926929
else
927-
ipoib_dbg(priv, "%s: failed cm send event "
930+
ipoib_warn(priv, "%s: failed cm send event "
928931
"(status=%d, wrid=%d vend_err 0x%x)\n",
929932
__func__, wc->status, wr_id, wc->vendor_err);
930933

0 commit comments

Comments
 (0)