Skip to content

Commit b3b51f9

Browse files
haggaiedledford
authored andcommitted
IB/cma: Potential NULL dereference in cma_id_from_event
If the lookup of a listening ID failed for an AF_IB request, the code would try to call dev_put() on a NULL net_dev. Fixes: be68819 ("IB/cma: Fix net_dev reference leak with failed requests") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Haggai Eran <[email protected]> Signed-off-by: Doug Ledford <[email protected]>
1 parent 3909642 commit b3b51f9

File tree

1 file changed

+1
-1
lines changed
  • drivers/infiniband/core

1 file changed

+1
-1
lines changed

drivers/infiniband/core/cma.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1324,7 +1324,7 @@ static struct rdma_id_private *cma_id_from_event(struct ib_cm_id *cm_id,
13241324
bind_list = cma_ps_find(rdma_ps_from_service_id(req.service_id),
13251325
cma_port_from_service_id(req.service_id));
13261326
id_priv = cma_find_listener(bind_list, cm_id, ib_event, &req, *net_dev);
1327-
if (IS_ERR(id_priv)) {
1327+
if (IS_ERR(id_priv) && *net_dev) {
13281328
dev_put(*net_dev);
13291329
*net_dev = NULL;
13301330
}

0 commit comments

Comments
 (0)