Skip to content

Commit b426995

Browse files
yonghong-songborkmann
authored andcommitted
tools/bpf: make libbpf _GNU_SOURCE friendly
During porting libbpf to bcc, I got some warnings like below: ... [ 2%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/libbpf.c.o /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf.c:12:0: warning: "_GNU_SOURCE" redefined [enabled by default] #define _GNU_SOURCE ... [ 3%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/libbpf_errno.c.o /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf_errno.c: In function ‘libbpf_strerror’: /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf_errno.c:45:7: warning: assignment makes integer from pointer without a cast [enabled by default] ret = strerror_r(err, buf, size); ... bcc is built with _GNU_SOURCE defined and this caused the above warning. This patch intends to make libpf _GNU_SOURCE friendly by . define _GNU_SOURCE in libbpf.c unless it is not defined . undefine _GNU_SOURCE as non-gnu version of strerror_r is expected. Signed-off-by: Yonghong Song <[email protected]> Acked-by: Jakub Kicinski <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]>
1 parent 1ad93ab commit b426995

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

tools/lib/bpf/libbpf.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
* Copyright (C) 2017 Nicira, Inc.
1010
*/
1111

12+
#ifndef _GNU_SOURCE
1213
#define _GNU_SOURCE
14+
#endif
1315
#include <stdlib.h>
1416
#include <stdio.h>
1517
#include <stdarg.h>

tools/lib/bpf/libbpf_errno.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* Copyright (C) 2017 Nicira, Inc.
88
*/
99

10+
#undef _GNU_SOURCE
1011
#include <stdio.h>
1112
#include <string.h>
1213

0 commit comments

Comments
 (0)