Skip to content

Commit b55cc4e

Browse files
committed
perf symbols: Rename ->ignore to ->idle
Since this is the only use thus far, and this mechanism is in place for a long time. To clarify why symbols should be skipped or treated differently, name it for the only use it has. Cc: Adrian Hunter <[email protected]> Cc: David Ahern <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Wang Nan <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent b01141f commit b55cc4e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tools/perf/builtin-top.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ static int symbol_filter(struct map *map, struct symbol *sym)
680680
return 1;
681681

682682
if (symbol__is_idle(sym))
683-
sym->ignore = true;
683+
sym->idle = 1;
684684

685685
return 0;
686686
}
@@ -783,7 +783,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
783783
}
784784
}
785785

786-
if (al.sym == NULL || !al.sym->ignore) {
786+
if (al.sym == NULL || !al.sym->idle) {
787787
struct hists *hists = evsel__hists(evsel);
788788
struct hist_entry_iter iter = {
789789
.evsel = evsel,

tools/perf/util/evsel_fprintf.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
122122
if (!node)
123123
break;
124124

125-
if (node->sym && node->sym->ignore)
125+
if (node->sym && node->sym->idle)
126126
goto next;
127127

128128
printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
@@ -181,7 +181,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,
181181
if (cursor != NULL) {
182182
printed += sample__fprintf_callchain(sample, left_alignment,
183183
print_opts, cursor, fp);
184-
} else if (!(al->sym && al->sym->ignore)) {
184+
} else if (!(al->sym && al->sym->idle)) {
185185
printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
186186

187187
if (print_ip)

tools/perf/util/symbol.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ struct symbol {
5757
u64 end;
5858
u16 namelen;
5959
u8 binding;
60-
bool ignore;
60+
u8 idle:1;
6161
u8 arch_sym;
6262
char name[0];
6363
};

0 commit comments

Comments
 (0)