Skip to content

Commit b642d48

Browse files
Ondrej Jirmanmripard
authored andcommitted
ARM: dts: sun8i-a83t-tbs-a711: Fix USB OTG mode detection
USB-ID signal has a pullup on the schematic, but in reality it's not pulled up, so add a GPIO pullup. And we also need a usb0_vbus_power-supply for VBUS detection. This fixes OTG mode detection and charging issues on TBS A711 tablet. The issues came from ID pin reading 0, causing host mode to be enabled, when it should not be, leading to DRVVBUS being enabled, which disabled the charger. Fixes: f2f221c ("ARM: dts: sun8i: a711: Enable USB OTG") Signed-off-by: Ondrej Jirman <[email protected]> Signed-off-by: Maxime Ripard <[email protected]>
1 parent a405509 commit b642d48

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,8 @@
498498
};
499499

500500
&usbphy {
501-
usb0_id_det-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
501+
usb0_id_det-gpios = <&pio 7 11 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH11 */
502+
usb0_vbus_power-supply = <&usb_power_supply>;
502503
usb0_vbus-supply = <&reg_drivevbus>;
503504
usb1_vbus-supply = <&reg_vmain>;
504505
usb2_vbus-supply = <&reg_vmain>;

0 commit comments

Comments
 (0)