Skip to content

Commit b67daab

Browse files
Michael Chandavem330
authored andcommitted
bnxt_en: Use dma_rmb() instead of rmb().
Use the weaker but more appropriate dma_rmb() to order the reading of the completion ring. Suggested-by: Ajit Khaparde <[email protected]> Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5049e33 commit b67daab

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-1
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1494,7 +1494,7 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget)
14941494
/* The valid test of the entry must be done first before
14951495
* reading any further.
14961496
*/
1497-
rmb();
1497+
dma_rmb();
14981498
if (TX_CMP_TYPE(txcmp) == CMP_TYPE_TX_L2_CMP) {
14991499
tx_pkts++;
15001500
/* return full budget so NAPI will complete. */

0 commit comments

Comments
 (0)