Skip to content

Commit b712c8d

Browse files
committed
x86: hpet: Use proper destructor for delayed work
destroy_timer_on_stack() is hardly the right thing for a delayed work. We leak a tracking object for the work itself when DEBUG_OBJECTS is enabled. Signed-off-by: Thomas Gleixner <[email protected]> Cc: Vince Weaver <[email protected]> Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
1 parent ea2e64f commit b712c8d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kernel/hpet.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ static int hpet_cpuhp_notify(struct notifier_block *n,
699699
/* FIXME: add schedule_work_on() */
700700
schedule_delayed_work_on(cpu, &work.work, 0);
701701
wait_for_completion(&work.complete);
702-
destroy_timer_on_stack(&work.work.timer);
702+
destroy_delayed_work_on_stack(&work.work);
703703
break;
704704
case CPU_DEAD:
705705
if (hdev) {

0 commit comments

Comments
 (0)