Skip to content

Commit b7f0554

Browse files
djbwtorvalds
authored andcommitted
mm: fail get_vaddr_frames() for filesystem-dax mappings
Until there is a solution to the dma-to-dax vs truncate problem it is not safe to allow V4L2, Exynos, and other frame vector users to create long standing / irrevocable memory registrations against filesytem-dax vmas. [[email protected]: add comment for vma_is_fsdax() check in get_vaddr_frames(), per Jan] Link: http://lkml.kernel.org/r/151197874035.26211.4061781453123083667.stgit@dwillia2-desk3.amr.corp.intel.com Link: http://lkml.kernel.org/r/151068939985.7446.15684639617389154187.stgit@dwillia2-desk3.amr.corp.intel.com Fixes: 3565fce ("mm, x86: get_user_pages() for dax mappings") Signed-off-by: Dan Williams <[email protected]> Reviewed-by: Jan Kara <[email protected]> Cc: Inki Dae <[email protected]> Cc: Seung-Woo Kim <[email protected]> Cc: Joonyoung Shim <[email protected]> Cc: Kyungmin Park <[email protected]> Cc: Mauro Carvalho Chehab <[email protected]> Cc: Mel Gorman <[email protected]> Cc: Vlastimil Babka <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Doug Ledford <[email protected]> Cc: Hal Rosenstock <[email protected]> Cc: Jason Gunthorpe <[email protected]> Cc: Jeff Moyer <[email protected]> Cc: Ross Zwisler <[email protected]> Cc: Sean Hefty <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 2bb6d28 commit b7f0554

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

mm/frame_vector.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,18 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames,
5353
ret = -EFAULT;
5454
goto out;
5555
}
56+
57+
/*
58+
* While get_vaddr_frames() could be used for transient (kernel
59+
* controlled lifetime) pinning of memory pages all current
60+
* users establish long term (userspace controlled lifetime)
61+
* page pinning. Treat get_vaddr_frames() like
62+
* get_user_pages_longterm() and disallow it for filesystem-dax
63+
* mappings.
64+
*/
65+
if (vma_is_fsdax(vma))
66+
return -EOPNOTSUPP;
67+
5668
if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) {
5769
vec->got_ref = true;
5870
vec->is_pfns = false;

0 commit comments

Comments
 (0)