Skip to content

Commit b7f294b

Browse files
committed
perf hists browser: The dso can be obtained from popup_action->ms.map->dso
So no need to have a 'dso' member in 'popup_action', remove it as no code is using it, already. Cc: Adrian Hunter <[email protected]> Cc: David Ahern <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Wang Nan <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent fae0065 commit b7f294b

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

tools/perf/ui/browsers/hists.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1430,7 +1430,6 @@ static int switch_data_file(void)
14301430

14311431
struct popup_action {
14321432
struct thread *thread;
1433-
struct dso *dso;
14341433
struct map_symbol ms;
14351434
int socket;
14361435

@@ -1565,7 +1564,6 @@ add_dso_opt(struct hist_browser *browser, struct popup_action *act,
15651564
return 0;
15661565

15671566
act->ms.map = map;
1568-
act->dso = map->dso;
15691567
act->fn = do_zoom_dso;
15701568
return 1;
15711569
}
@@ -1827,7 +1825,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
18271825

18281826
while (1) {
18291827
struct thread *thread = NULL;
1830-
struct dso *dso = NULL;
18311828
struct map *map = NULL;
18321829
int choice = 0;
18331830
int socked_id = -1;
@@ -1839,8 +1836,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
18391836
if (browser->he_selection != NULL) {
18401837
thread = hist_browser__selected_thread(browser);
18411838
map = browser->selection->map;
1842-
if (map)
1843-
dso = map->dso;
18441839
socked_id = browser->he_selection->socket;
18451840
}
18461841
switch (key) {
@@ -1874,7 +1869,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
18741869
hist_browser__dump(browser);
18751870
continue;
18761871
case 'd':
1877-
actions->dso = dso;
18781872
actions->ms.map = map;
18791873
do_zoom_dso(browser, actions);
18801874
continue;

0 commit comments

Comments
 (0)