Skip to content

Commit b833eb2

Browse files
committed
dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC
Samsung Exynos SoC reuses several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. Reviewed-by: Alim Akhtar <[email protected]> Acked-by: Rob Herring <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent b85ea95 commit b833eb2

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,21 @@ description: |
2828
2929
properties:
3030
compatible:
31-
enum:
32-
- samsung,s3c2410-wakeup-eint
33-
- samsung,s3c2412-wakeup-eint
34-
- samsung,s3c64xx-wakeup-eint
35-
- samsung,s5pv210-wakeup-eint
36-
- samsung,exynos4210-wakeup-eint
37-
- samsung,exynos7-wakeup-eint
38-
- samsung,exynos850-wakeup-eint
39-
- samsung,exynosautov9-wakeup-eint
31+
oneOf:
32+
- enum:
33+
- samsung,s3c2410-wakeup-eint
34+
- samsung,s3c2412-wakeup-eint
35+
- samsung,s3c64xx-wakeup-eint
36+
- samsung,s5pv210-wakeup-eint
37+
- samsung,exynos4210-wakeup-eint
38+
- samsung,exynos7-wakeup-eint
39+
- samsung,exynos850-wakeup-eint
40+
- samsung,exynosautov9-wakeup-eint
41+
- items:
42+
- enum:
43+
- samsung,exynos5433-wakeup-eint
44+
- samsung,exynos7885-wakeup-eint
45+
- const: samsung,exynos7-wakeup-eint
4046

4147
interrupts:
4248
description:

Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,8 @@ examples:
313313
pinctrl-0 = <&initial_alive>;
314314
315315
wakeup-interrupt-controller {
316-
compatible = "samsung,exynos7-wakeup-eint";
316+
compatible = "samsung,exynos5433-wakeup-eint",
317+
"samsung,exynos7-wakeup-eint";
317318
interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
318319
};
319320

0 commit comments

Comments
 (0)