Skip to content

Commit b843299

Browse files
Dave Chinnerdjwong
authored andcommitted
xfs: remove some stale comments from the log code
Signed-off-by: Dave Chinner <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Brian Foster <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> Signed-off-by: Darrick J. Wong <[email protected]>
1 parent 3c702f9 commit b843299

File tree

1 file changed

+13
-46
lines changed

1 file changed

+13
-46
lines changed

fs/xfs/xfs_log.c

Lines changed: 13 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -463,14 +463,6 @@ xfs_log_reserve(
463463
return error;
464464
}
465465

466-
467-
/*
468-
* NOTES:
469-
*
470-
* 1. currblock field gets updated at startup and after in-core logs
471-
* marked as with WANT_SYNC.
472-
*/
473-
474466
static bool
475467
__xlog_state_release_iclog(
476468
struct xlog *log,
@@ -1915,7 +1907,7 @@ xlog_dealloc_log(
19151907
log->l_mp->m_log = NULL;
19161908
destroy_workqueue(log->l_ioend_workqueue);
19171909
kmem_free(log);
1918-
} /* xlog_dealloc_log */
1910+
}
19191911

19201912
/*
19211913
* Update counters atomically now that memcpy is done.
@@ -2458,14 +2450,6 @@ xlog_write(
24582450
return error;
24592451
}
24602452

2461-
2462-
/*****************************************************************************
2463-
*
2464-
* State Machine functions
2465-
*
2466-
*****************************************************************************
2467-
*/
2468-
24692453
static void
24702454
xlog_state_activate_iclog(
24712455
struct xlog_in_core *iclog,
@@ -2826,7 +2810,7 @@ xlog_state_done_syncing(
28262810
*/
28272811
wake_up_all(&iclog->ic_write_wait);
28282812
spin_unlock(&log->l_icloglock);
2829-
xlog_state_do_callback(log); /* also cleans log */
2813+
xlog_state_do_callback(log);
28302814
}
28312815

28322816
/*
@@ -2946,13 +2930,14 @@ xlog_state_get_iclog_space(
29462930

29472931
*logoffsetp = log_offset;
29482932
return 0;
2949-
} /* xlog_state_get_iclog_space */
2933+
}
29502934

29512935
/*
2952-
* The first cnt-1 times through here we don't need to move the grant write head
2953-
* because the permanent reservation has reserved cnt times the unit amount.
2954-
* Release part of current permanent unit reservation and reset current
2955-
* reservation to be one units worth. Also move grant reservation head forward.
2936+
* The first cnt-1 times a ticket goes through here we don't need to move the
2937+
* grant write head because the permanent reservation has reserved cnt times the
2938+
* unit amount. Release part of current permanent unit reservation and reset
2939+
* current reservation to be one units worth. Also move grant reservation head
2940+
* forward.
29562941
*/
29572942
void
29582943
xfs_log_ticket_regrant(
@@ -3034,12 +3019,8 @@ xfs_log_ticket_ungrant(
30343019
}
30353020

30363021
/*
3037-
* Mark the current iclog in the ring as WANT_SYNC and move the current iclog
3038-
* pointer to the next iclog in the ring.
3039-
*
3040-
* When called from xlog_state_get_iclog_space(), the exact size of the iclog
3041-
* has not yet been determined, all we know is that we have run out of space in
3042-
* the current iclog.
3022+
* This routine will mark the current iclog in the ring as WANT_SYNC and move
3023+
* the current iclog pointer to the next iclog in the ring.
30433024
*/
30443025
STATIC void
30453026
xlog_state_switch_iclogs(
@@ -3084,7 +3065,7 @@ xlog_state_switch_iclogs(
30843065
}
30853066
ASSERT(iclog == log->l_iclog);
30863067
log->l_iclog = iclog->ic_next;
3087-
} /* xlog_state_switch_iclogs */
3068+
}
30883069

30893070
/*
30903071
* Write out all data in the in-core log as of this exact moment in time.
@@ -3291,13 +3272,6 @@ xfs_log_force_lsn(
32913272
return ret;
32923273
}
32933274

3294-
/*****************************************************************************
3295-
*
3296-
* TICKET functions
3297-
*
3298-
*****************************************************************************
3299-
*/
3300-
33013275
/*
33023276
* Free a used ticket when its refcount falls to zero.
33033277
*/
@@ -3454,13 +3428,6 @@ xlog_ticket_alloc(
34543428
return tic;
34553429
}
34563430

3457-
3458-
/******************************************************************************
3459-
*
3460-
* Log debug routines
3461-
*
3462-
******************************************************************************
3463-
*/
34643431
#if defined(DEBUG)
34653432
/*
34663433
* Make sure that the destination ptr is within the valid data region of
@@ -3546,7 +3513,7 @@ xlog_verify_tail_lsn(
35463513
if (blocks < BTOBB(iclog->ic_offset) + 1)
35473514
xfs_emerg(log->l_mp, "%s: ran out of log space", __func__);
35483515
}
3549-
} /* xlog_verify_tail_lsn */
3516+
}
35503517

35513518
/*
35523519
* Perform a number of checks on the iclog before writing to disk.
@@ -3649,7 +3616,7 @@ xlog_verify_iclog(
36493616
}
36503617
ptr += sizeof(xlog_op_header_t) + op_len;
36513618
}
3652-
} /* xlog_verify_iclog */
3619+
}
36533620
#endif
36543621

36553622
/*

0 commit comments

Comments
 (0)