Skip to content

Commit b89a07c

Browse files
cohuckmstsirkin
authored andcommitted
virtio: fix virtio_config_ops description
- get_features has returned 64 bits since commit d025477 ("virtio: add support for 64 bit features.") - properly mark all optional callbacks Signed-off-by: Cornelia Huck <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Halil Pasic <[email protected]>
1 parent 1c7fc5c commit b89a07c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

include/linux/virtio_config.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ struct irq_affinity;
2222
* offset: the offset of the configuration field
2323
* buf: the buffer to read the field value from.
2424
* len: the length of the buffer
25-
* @generation: config generation counter
25+
* @generation: config generation counter (optional)
2626
* vdev: the virtio_device
2727
* Returns the config generation counter
2828
* @get_status: read the status byte
@@ -48,17 +48,17 @@ struct irq_affinity;
4848
* @del_vqs: free virtqueues found by find_vqs().
4949
* @get_features: get the array of feature bits for this device.
5050
* vdev: the virtio_device
51-
* Returns the first 32 feature bits (all we currently need).
51+
* Returns the first 64 feature bits (all we currently need).
5252
* @finalize_features: confirm what device features we'll be using.
5353
* vdev: the virtio_device
5454
* This gives the final feature bits for the device: it can change
5555
* the dev->feature bits if it wants.
5656
* Returns 0 on success or error status
57-
* @bus_name: return the bus name associated with the device
57+
* @bus_name: return the bus name associated with the device (optional)
5858
* vdev: the virtio_device
5959
* This returns a pointer to the bus name a la pci_name from which
6060
* the caller can then copy.
61-
* @set_vq_affinity: set the affinity for a virtqueue.
61+
* @set_vq_affinity: set the affinity for a virtqueue (optional).
6262
* @get_vq_affinity: get the affinity for a virtqueue (optional).
6363
*/
6464
typedef void vq_callback_t(struct virtqueue *);

0 commit comments

Comments
 (0)